fix(core): Guard loadModule default parameter against ESM scope - #24124
Open
chargome wants to merge 1 commit into
Open
fix(core): Guard loadModule default parameter against ESM scope#24124chargome wants to merge 1 commit into
loadModule default parameter against ESM scope#24124chargome wants to merge 1 commit into
Conversation
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0770e69. Configure here.
Default parameters are evaluated before the function body, so the bare `module` default threw `ReferenceError: module is not defined` from the ESM build before reaching the try/catch that is meant to make `loadModule` degrade gracefully. Guard it with a `typeof module` check so ESM callers get `undefined` instead. Fixes #24117 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
force-pushed
the
investigate-loadmodule-es
branch
from
September 7, 2026 07:56
8908e3e to
c6c97f3
Compare
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
September 7, 2026 08:38
chargome
requested review from
isaacs,
mydea and
timfish
and removed request for
a team
September 7, 2026 08:38
timfish
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard
loadModule's defaultexistingModuleparameter with atypeof modulecheck so calling it from the ESM build degrades toundefinedinstead of throwingReferenceError: module is not defined, since default parameters are evaluated before the function's try/catch. Fixes #24117