fix(core): Stop supabaseIntegration from ending spans twice - #24126
Open
chargome wants to merge 1 commit into
Open
fix(core): Stop supabaseIntegration from ending spans twice#24126chargome wants to merge 1 commit into
supabaseIntegration from ending spans twice#24126chargome wants to merge 1 commit into
Conversation
The Supabase auth and PostgREST wrappers end their spans by hand once the wrapped promise settles, but they ran inside a startSpan callback that also ends the span when the callback's promise resolves. Every instrumented call therefore ended its span twice, and OTel diag loggers reported "You can only call end() on a span once" for each one. Switch both wrappers to startSpanManual so the manual end is the only one. Dropping the manual end instead would have extended each span to include the caller's own then handlers, which the wrapper chains onto the promise it returns. Fixes #24116 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e6a1eaf. Configure here.
Contributor
size-limit report 📦
|
chargome
marked this pull request as ready for review
September 7, 2026 08:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the Supabase auth and PostgREST wrappers to
startSpanManual, since they already end their spans by hand andstartSpan's automatic end was ending every span a second time, which spams OTel diag loggers with "You can only call end() on a span once".Fixes #24116