Skip to content

perf(native): Sync scope over IPC - #2157

Merged
jpnurmi merged 3 commits into
jpnurmi/perf/native-ipcfrom
jpnurmi/perf/native-ipc-sync
Oct 16, 2026
Merged

jpnurmi merged 3 commits into
jpnurmi/perf/native-ipcfrom
jpnurmi/perf/native-ipc-sync

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

Instead of flushing the whole scope/event on disk on every scope change, send an initial scope snapshot and then minimal incremental updates to the crash daemon over IPC.

Keep the latest complete state in daemon memory for crash reports. Discard interrupted messages and preserve crash callback changes through a final event and attachment snapshot.

See the native (purple) lines in related benchmarks:

Untitled

Close: #1834

@jpnurmi
jpnurmi added this pull request to stack #2156 October 2, 2026 06:23

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread src/backends/native/sentry_crash_ipc.c
Comment thread src/backends/native/sentry_crash_daemon.c
Comment thread src/backends/native/sentry_crash_daemon.c
Comment thread src/sentry_scope.c
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/native-ipc-sync branch from 3628eda to bdf71d5 Compare October 2, 2026 06:40

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

Comment thread src/backends/native/sentry_crash_daemon.c
Comment thread src/sentry_scope.c
Comment thread src/backends/sentry_backend_native.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/native-ipc-sync branch from bdf71d5 to 941bf3b Compare October 2, 2026 06:50
@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.30701% with 213 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.36%. Comparing base (36d6e7f) to head (f00c436).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           jpnurmi/perf/native-ipc    #2157      +/-   ##
===========================================================
+ Coverage                    74.88%   75.36%   +0.47%     
===========================================================
  Files                          104      104              
  Lines                        29089    29630     +541     
  Branches                      5370     5479     +109     
===========================================================
+ Hits                         21783    22330     +547     
+ Misses                        5928     5883      -45     
- Partials                      1378     1417      +39     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/native-ipc-sync branch from 9e953e7 to 9f80d41 Compare October 2, 2026 14:05
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/native-ipc-sync branch from 9f80d41 to a084959 Compare October 5, 2026 15:15
@jpnurmi jpnurmi added the v1 Targets 1.0 (v1 branch) label Oct 14, 2026
@jpnurmi
jpnurmi removed this pull request from stack #2156 October 16, 2026 07:05
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/native-ipc-sync branch from a084959 to aada185 Compare October 16, 2026 07:45
@jpnurmi
jpnurmi added this pull request to stack #2210 October 16, 2026 07:45
Instead of flushing the whole scope/event on disk on every scope
change, send an initial scope snapshot and then minimal incremental
updates to the crash daemon over IPC.

Keep the latest complete state in daemon memory for crash reports.
Discard interrupted messages and preserve crash callback changes through
a final event and attachment snapshot.

Close: #1834
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/native-ipc-sync branch from aada185 to 616176b Compare October 16, 2026 07:48

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 616176b. Configure here.

Comment thread src/backends/native/sentry_crash_daemon.c
@jpnurmi
jpnurmi merged commit 4ce28e7 into v1 Oct 16, 2026
67 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/perf/native-ipc-sync branch October 16, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 Targets 1.0 (v1 branch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native: use IPC instead of flushing to disk where possible

2 participants