feat!: 1.0 by jpnurmi · Pull Request #2196 · getsentry/sentry-native

jpnurmi · 2026-10-14T06:46:58Z

Warning

WIP 🚧🔨⏳⛔

Close: #2044

#skip-changelog (WIP)

Run CI on `v1` like on `master`, and dispatch console compatibility checks to the same-named console branch for commits cut from `v1`.

cursor

Stale Bugbot comment from a previous run.

codecov · 2026-10-14T07:06:59Z

Codecov Report

❌ Patch coverage is 75.13562% with 550 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.13%. Comparing base (6376e9d) to head (4ce28e7).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
- Coverage   75.42%   75.13%   -0.29%     
==========================================
  Files         103      104       +1     
  Lines       28254    29630    +1376     
  Branches     5177     5479     +302     
==========================================
+ Hits        21310    22263     +953     
- Misses       5600     5960     +360     
- Partials     1344     1407      +63

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The collective PR runs CI on every push to v1 already.

cursor

Stale Bugbot comment from a previous run.

Pull request analyses are stored against the merge ref, so PRs into v1 had no baseline and compared against master.

Set CMake [`VERSION`](https://cmake.org/cmake/help/latest/prop_tgt/VERSION.html) and [`SOVERSION`](https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html) properties. Close: #1428

* ci: include version in the release archive name Fixes: #745 * ci: keep a stable archive name for latest downloads Create a `sentry-native.zip` copy for the GCS `latest/` path so each release replaces the same object. Keep versioned archive names for GitHub and version-specific GCS paths.

BREAKING CHANGE: Linux, macOS, and Windows builds now default to the `native` backend instead of `crashpad`.

The custom capture hook required private SDK types, while screenshot options were still experimental. BREAKING CHANGE: Implement sentry_screenshot_capture(const char *, uint32_t), returning 0 on success.

The factory used a private-style `sentry__`-prefixed name even though custom transports must provide its implementation. Give it a public-style name and document the contract for custom implementations. BREAKING CHANGE: Custom transport implementations must define: ``` sentry_transport_t *sentry_transport_new_default(void) ```

cursor

Stale Bugbot comment from a previous run.

Keep the scope write lock across a batch while allowing the owning thread to use existing scope accessors without relocking. Defer backend scope flushes until the outermost batch completes.

Split the existing global scope into an internal, read-only global scope for SDK/OS metadata and configured defaults, and a mutable isolation scope used by top-level APIs. Move user data, observers, and backend flushing to the isolation scope. Add `sentry_scope_acquire()` and `sentry_scope_release()` for direct isolation scope access. Implement Sentry's three-scope model with global -> isolation -> local scope layering. Retain parent references and merge layers when preparing events, telemetry, and attachments. Local values take precedence over isolation and global defaults. The SDK follows the global mode used by other Sentry SDKs for client applications: all threads share the same process-wide isolation scope. Changes made through top-level APIs or an acquired reference are shared across all threads. See: - https://develop.sentry.dev/sdk/foundations/state-management/scopes/#isolation-scope

cursor

Stale Bugbot comment from a previous run.

Provide exception metadata, registers, and a basic crashing-thread stack for crash identification in native `on_crash`, matching `inproc`. Use the same payload for `before_send` when `on_crash` is unset. - Capture up to 128 fault-context IPs and unwind source in shared memory. Retain the faulting IP when available. - Linux: SDK `libunwind` with signal-safe logging. - macOS: SDK frame-pointer walker, guarded Mach reads, PAC stripping, `__DARWIN_OPAQUE_ARM_THREAD_STATE64` accessors, and `instruction_addr_adjustment=none`. - Android/Linux without `libunwind`: bounded frame-pointer capture via `process_vm_readv`; avoids `libunwindstack`'s C++ allocation. - Windows: MSVC x64 `RtlLookupFunctionEntry`/`RtlVirtualUnwind` walking without DbgHelp; SP progress permits recursive frames. Frame-pointer capture on x86/ARM64 and other x64 builds. - ARM32 frame-pointer fallbacks retain only the faulting IP. The daemon reuses partial captures and enriches existing frames. Preserve exception/register/frame edits and removals, and honor callback rejection.

Promote the 5-6 years old module API, also used by downstream SDKs, now that it's usable for direct Native SDK users for comparing frame addresses with module ranges. Ref: #2102 Ref: #2116

cursor

Stale Bugbot comment from a previous run.

cursor

Stale Bugbot comment from a previous run.

Skip Windows frame symbol lookup when symbolize_stacktraces is disabled, including crash frames captured before daemon processing.

Add length-prefixed frames and app-to-daemon IPC based on Unix domain stream socket pairs and an anonymous pipe on Windows. Ref: #1834

* perf(native): Sync scope over IPC Instead of flushing the whole scope/event on disk on every scope change, send an initial scope snapshot and then minimal incremental updates to the crash daemon over IPC. Keep the latest complete state in daemon memory for crash reports. Discard interrupted messages and preserve crash callback changes through a final event and attachment snapshot. Close: #1834 * handle SENTRY_CRASH_STATE_CRASHING * signal.h

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4ce28e7. Configure here.}

cursor · 2026-10-16T10:31:35Z

+        : sentry_value_new_null();
+    if (sentry_value_is_null(attachments)) {
+        attachments = sentry_value_incref(ipc->scope.attachments);
+    }


Empty attachments fall back to staged list

High Severity

A crash-time __sentry-attachments write with no items is treated as a missing manifest. sentry__read_attachment_manifest turns an empty list into null, and sentry__process_crash then substitutes ipc->scope.attachments. Attachments cleared in on_crash or via the hint can still be uploaded with the crash.

^{Reviewed by Cursor Bugbot for commit 4ce28e7. Configure here.}

cursor · 2026-10-16T10:31:35Z

+        sentry_value_t filename_val
+            = sentry_value_get_by_key(attach_info, "filename");
+        sentry_value_t attachment_type_val
+            = sentry_value_get_by_key(attach_info, "attachment_type");


Crash attachments lose type field

Medium Severity

The daemon envelope writers read attachment_type, but crash-time manifests from sentry__write_attachment_manifest store that value as type. After a normal on_crash snapshot, the disk list is preferred over IPC, so attachment_type is empty and types such as view hierarchy are dropped.

Additional Locations (2)

src/backends/native/sentry_crash_daemon.c#L3888-L3890

src/backends/sentry_backend_native.c#L1238-L1241

^{Reviewed by Cursor Bugbot for commit 4ce28e7. Configure here.}

ci: Support v1 version branch

6f4dc99

Run CI on `v1` like on `master`, and dispatch console compatibility checks to the same-named console branch for commits cut from `v1`.

cursor Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread .github/workflows/console-check.yml

ci: Drop v1 push filters

8dc1bfb

The collective PR runs CI on every push to v1 already.

cursor Bot reviewed Oct 14, 2026

View reviewed changes

Comment thread .github/workflows/codeql.yml Outdated

jpnurmi added 8 commits October 14, 2026 09:41

ci(codeql): Analyze v1 pushes

212b6a6

Pull request analyses are stored against the merge ref, so PRs into v1 had no baseline and compared against master.

feat(build): shared library version (#2103)

a6ee584

Set CMake [`VERSION`](https://cmake.org/cmake/help/latest/prop_tgt/VERSION.html) and [`SOVERSION`](https://cmake.org/cmake/help/latest/prop_tgt/SOVERSION.html) properties. Close: #1428

feat!: make native the default backend (#2186)

67e0b6d

BREAKING CHANGE: Linux, macOS, and Windows builds now default to the `native` backend instead of `crashpad`.

ci: Publish v1 benchmarks separately

6dcddc8

Merge remote-tracking branch 'origin/master' into v1

1e8a9bc

ref: stabilize screenshot APIs (#2204)

3d26077

The custom capture hook required private SDK types, while screenshot options were still experimental. BREAKING CHANGE: Implement sentry_screenshot_capture(const char *, uint32_t), returning 0 on success.

cursor Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread src/sentry_options.c

jpnurmi added 2 commits October 15, 2026 15:06

perf: add support for batched scope updates (#2107)

a0e2564

Keep the scope write lock across a batch while allowing the owning thread to use existing scope accessors without relocking. Defer backend scope flushes until the outermost batch completes.

cursor Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread src/sentry_scope.c

jpnurmi added 2 commits October 15, 2026 17:44

fix: provide debug_meta.images to on_crash (#2184)

bcbca11

Promote the 5-6 years old module API, also used by downstream SDKs, now that it's usable for direct Native SDK users for comparing frame addresses with module ranges. Ref: #2102 Ref: #2116

cursor Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread src/backends/native/sentry_crash_daemon.c

Merge remote-tracking branch 'origin/master' into v1

cc54b28

cursor Bot reviewed Oct 15, 2026

View reviewed changes

Comment thread src/backends/native/sentry_crash_context.h

jpnurmi added 3 commits October 16, 2026 07:35

fix(native): honor symbolication option for captured Windows frames

e550d2f

Skip Windows frame symbol lookup when symbolize_stacktraces is disabled, including crash frames captured before daemon processing.

perf(native): Add IPC foundations (#2155)

0f5e3a2

Add length-prefixed frames and app-to-daemon IPC based on Unix domain stream socket pairs and an anonymous pipe on Windows. Ref: #1834

cursor Bot reviewed Oct 16, 2026

View reviewed changes

jpnurmi added the v1 Targets 1.0 (v1 branch) label Oct 16, 2026

Conversation

jpnurmi commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WIP 🚧🔨⏳⛔

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Oct 16, 2026

Choose a reason for hiding this comment

Empty attachments fall back to staged list

Uh oh!

cursor Bot Oct 16, 2026

Choose a reason for hiding this comment

Crash attachments lose type field

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jpnurmi commented Oct 14, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

codecov Bot commented Oct 14, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading