Skip to content

fix(native): enable WER crash handling on Xbox - #2207

Merged
jpnurmi merged 4 commits into
masterfrom
jpnurmi/fix/xbox-wer-compat
Oct 16, 2026
Merged

jpnurmi merged 4 commits into
masterfrom
jpnurmi/fix/xbox-wer-compat

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

With these changes, integration tests succeed in capturing WER report IDs for fast-fail crashes at https://github.com/getsentry/sentry-xbox/pull/189.

  • Build sentry-wer.dll with system UCRT and static VCRuntime to allow WerFault.exe to load it successfully
  • Resolve WER registration symbols dynamically (WerRegisterRuntimeExceptionModule is not available in xgameplatform.lib), and use Xbox-compatible registry calls:
      Building against GXDK Edition 250401.
      sentry_backend_native.c
    sentry_backend_native.obj : error LNK2019: unresolved external symbol RegSetKeyValueW referenced in function wer_register_module [C:\Users\jpnurmi\Projects
    \sentry\sentry-xbox\build\xboxone-outproc\_deps\sentry-native-build\sentry-crash.vcxproj]
    sentry_backend_native.obj : error LNK2019: unresolved external symbol RegDeleteKeyValueW referenced in function native_backend_shutdown [C:\Users\jpnurmi\P
    rojects\sentry\sentry-xbox\build\xboxone-outproc\_deps\sentry-native-build\sentry-crash.vcxproj]
    sentry_backend_native.obj : error LNK2019: unresolved external symbol WerUnregisterRuntimeExceptionModule referenced in function native_backend_shutdown [C
    :\Users\jpnurmi\Projects\sentry\sentry-xbox\build\xboxone-outproc\_deps\sentry-native-build\sentry-crash.vcxproj]
    sentry_backend_native.obj : error LNK2019: unresolved external symbol WerRegisterRuntimeExceptionModule referenced in function wer_register_module [C:\User
    s\jpnurmi\Projects\sentry\sentry-xbox\build\xboxone-outproc\_deps\sentry-native-build\sentry-crash.vcxproj]
    C:\Users\jpnurmi\Projects\sentry\sentry-xbox\build\xboxone-outproc\_deps\sentry-native-build\Release\sentry-crash.exe : fatal error LNK1120: 4 unresolved e
    xternals [C:\Users\jpnurmi\Projects\sentry\sentry-xbox\build\xboxone-outproc\_deps\sentry-native-build\sentry-crash.vcxproj]
    

Ref:

  • getsentry/sentry-xbox#187

Build the helper with system UCRT and static VCRuntime for WerFault.
Resolve registration APIs dynamically, use Xbox-compatible registry
calls, and enable the daemon's WER metadata wait.
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.53%. Comparing base (c549939) to head (7c512dd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2207      +/-   ##
==========================================
- Coverage   75.57%   75.53%   -0.04%     
==========================================
  Files         103      103              
  Lines       28244    28261      +17     
  Branches     5173     5179       +6     
==========================================
+ Hits        21344    21347       +3     
- Misses       5556     5577      +21     
+ Partials     1344     1337       -7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jpnurmi
jpnurmi marked this pull request as ready for review October 15, 2026 14:52
@jpnurmi
jpnurmi merged commit 512d738 into master Oct 16, 2026
70 checks passed
@jpnurmi
jpnurmi deleted the jpnurmi/fix/xbox-wer-compat branch October 16, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants