Skip to content

test(cohere): Parametrize tests on the streaming trace lifecycle #7419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 3 commits into from
Sep 8, 2026
Merged

test(cohere): Parametrize tests on the streaming trace lifecycle #7419

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af90c7b
test(cohere): Parametrize tests on the streaming trace lifecycle
alexander-alderman-webb Sep 7, 2026
9d343f4
.
alexander-alderman-webb Sep 7, 2026
7f0138c
parametrize test_bad_chat
alexander-alderman-webb Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
203 changes: 145 additions & 58 deletions tests/integrations/cohere/test_cohere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,20 +249,43 @@ def test_streaming_chat(
assert span["data"]["gen_ai.usage.total_tokens"] == 30


def test_bad_chat(sentry_init, capture_events):
sentry_init(integrations=[CohereIntegration()], traces_sample_rate=1.0)
events = capture_events()

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
side_effect=httpx.HTTPError("API rate limit reached")
@pytest.mark.parametrize("span_streaming", [True, False])
def test_bad_chat(sentry_init, capture_events, capture_items, span_streaming):
sentry_init(
integrations=[CohereIntegration()],
traces_sample_rate=1.0,
trace_lifecycle="stream" if span_streaming else "static",
)
with pytest.raises(httpx.HTTPError):
client.chat(model="some-model", message="hello")

(event, transaction) = events
assert event["level"] == "error"
assert transaction["contexts"]["trace"]["status"] == "internal_error"
if span_streaming:
items = capture_items("event", "span")

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
side_effect=httpx.HTTPError("API rate limit reached")
)
with pytest.raises(httpx.HTTPError):
client.chat(model="some-model", message="hello")

(event,) = (item.payload for item in items if item.type == "event")
assert event["level"] == "error"

sentry_sdk.flush()
(span,) = (item.payload for item in items if item.type == "span")
assert span["status"] == "error"
else:
events = capture_events()

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
side_effect=httpx.HTTPError("API rate limit reached")
)
with pytest.raises(httpx.HTTPError):
client.chat(model="some-model", message="hello")

(event, transaction) = events
assert event["level"] == "error"
assert transaction["contexts"]["trace"]["status"] == "internal_error"


def test_span_status_error(sentry_init, capture_events):
Expand Down Expand Up @@ -386,74 +409,138 @@ def test_embed(
assert span["data"]["gen_ai.usage.total_tokens"] == 10


def test_span_origin_chat(sentry_init, capture_events):
@pytest.mark.parametrize("span_streaming", [True, False])
def test_span_origin_chat(sentry_init, capture_events, capture_items, span_streaming):
sentry_init(
integrations=[CohereIntegration()],
traces_sample_rate=1.0,
trace_lifecycle="stream" if span_streaming else "static",
)
events = capture_events()

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
return_value=httpx.Response(
200,
json={
"text": "the model response",
"meta": {
"billed_units": {
"output_tokens": 10,
"input_tokens": 20,
}
if span_streaming:
items = capture_items("span")

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
return_value=httpx.Response(
200,
json={
"text": "the model response",
"meta": {
"billed_units": {
"output_tokens": 10,
"input_tokens": 20,
}
},
},
},
)
)
)

with start_transaction(name="cohere tx"):
client.chat(
model="some-model",
chat_history=[ChatMessage(role="SYSTEM", message="some context")],
message="hello",
).text
with start_transaction(name="cohere tx"):
client.chat(
model="some-model",
chat_history=[ChatMessage(role="SYSTEM", message="some context")],
message="hello",
).text

(event,) = events
sentry_sdk.flush()
(span,) = (item.payload for item in items)
assert span["attributes"]["sentry.origin"] == "auto.ai.cohere"
else:
events = capture_events()

assert event["contexts"]["trace"]["origin"] == "manual"
assert event["spans"][0]["origin"] == "auto.ai.cohere"
client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
return_value=httpx.Response(
200,
json={
"text": "the model response",
"meta": {
"billed_units": {
"output_tokens": 10,
"input_tokens": 20,
}
},
},
)
)

with start_transaction(name="cohere tx"):
client.chat(
model="some-model",
chat_history=[ChatMessage(role="SYSTEM", message="some context")],
message="hello",
).text

(event,) = events

assert event["contexts"]["trace"]["origin"] == "manual"
assert event["spans"][0]["origin"] == "auto.ai.cohere"


def test_span_origin_embed(sentry_init, capture_events):
@pytest.mark.parametrize("span_streaming", [True, False])
def test_span_origin_embed(sentry_init, capture_events, capture_items, span_streaming):
sentry_init(
integrations=[CohereIntegration()],
traces_sample_rate=1.0,
trace_lifecycle="stream" if span_streaming else "static",
)
events = capture_events()

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
return_value=httpx.Response(
200,
json={
"response_type": "embeddings_floats",
"id": "1",
"texts": ["hello"],
"embeddings": [[1.0, 2.0, 3.0]],
"meta": {
"billed_units": {
"input_tokens": 10,
}
if span_streaming:
items = capture_items("span")

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
return_value=httpx.Response(
200,
json={
"response_type": "embeddings_floats",
"id": "1",
"texts": ["hello"],
"embeddings": [[1.0, 2.0, 3.0]],
"meta": {
"billed_units": {
"input_tokens": 10,
}
},
},
},
)
)
)

with start_transaction(name="cohere tx"):
client.embed(texts=["hello"], model="text-embedding-3-large")
with start_transaction(name="cohere tx"):
client.embed(texts=["hello"], model="text-embedding-3-large")

sentry_sdk.flush()
(span,) = (item.payload for item in items)
assert span["attributes"]["sentry.origin"] == "auto.ai.cohere"
else:
events = capture_events()

client = Client(api_key="z")
HTTPXClient.request = mock.Mock(
return_value=httpx.Response(
200,
json={
"response_type": "embeddings_floats",
"id": "1",
"texts": ["hello"],
"embeddings": [[1.0, 2.0, 3.0]],
"meta": {
"billed_units": {
"input_tokens": 10,
}
},
},
)
)

with start_transaction(name="cohere tx"):
client.embed(texts=["hello"], model="text-embedding-3-large")

(event,) = events
(event,) = events

assert event["contexts"]["trace"]["origin"] == "manual"
assert event["spans"][0]["origin"] == "auto.ai.cohere"
assert event["contexts"]["trace"]["origin"] == "manual"
assert event["spans"][0]["origin"] == "auto.ai.cohere"


# data_collection config, send_default_pii, include_prompts, expect_inputs, expect_outputs
Expand Down
Loading