ref(asgi): Drop send_default_pii support in _get_request_data - #7768
Merged
Merged
Conversation
Always filter the query string through the `data_collection` `url_query_params` setting. The legacy `send_default_pii` path is resolved into an equivalent `data_collection` default, so the raw query string is no longer passed through. Update the Django ASGI and FastAPI tests to configure `data_collection` instead of `send_default_pii`. Refs PY-2798 Refs #7566
…uest_data` Read `REMOTE_ADDR` from `data_collection["user_info"]` only. The client already resolves `send_default_pii` into `data_collection` at init, so the legacy `should_send_default_pii()` fallback is redundant. Update the ASGI and Django ASGI tests to configure `data_collection` instead of `send_default_pii`, and remove the legacy `send_default_pii` parametrized cases.
ericapisani
marked this pull request as ready for review
September 29, 2026 17:14
Contributor
Codecov Results 📊✅ 58521 passed | ⏭️ 2727 skipped | Total: 61248 | Pass Rate: 95.55% | Execution Time: 156m 52s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2054 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.36% 90.19% -0.17%
==========================================
Files 199 183 -16
Lines 26526 20946 -5580
Branches 9866 7326 -2540
==========================================
+ Hits 23971 18892 -5079
- Misses 2555 2054 -501
- Partials 1495 1216 -279Generated by Codecov Action |
ericapisani
added this pull request to stack #7770
September 29, 2026 17:25
ericapisani
removed this pull request from stack #7770
September 29, 2026 17:26
ericapisani
added this pull request to stack #7771
September 29, 2026 17:26
alexander-alderman-webb
approved these changes
Sep 30, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6cf7784. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always filter the query string through the
data_collectionurl_query_paramssetting. The legacysend_default_piipath isresolved into an equivalent
data_collectiondefault, so the rawquery string is no longer passed through.
Update the Django ASGI and FastAPI tests to configure
data_collectioninstead ofsend_default_pii.Refs PY-2798
Refs #7566