Skip to content

ref(asgi): Drop send_default_pii support in _get_request_attributes - #7769

Merged
ericapisani merged 3 commits into
py-2798-update-asgi-get-request-datafrom
py-2798-update-asgi-get-request-attributes
Oct 1, 2026
Merged

ericapisani merged 3 commits into
py-2798-update-asgi-get-request-datafrom
py-2798-update-asgi-get-request-attributes

Conversation

@ericapisani

@ericapisani ericapisani commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Remove the legacy send_default_pii fallback branches and always
gate http.query, url.path, url.full and client.address on
data_collection.

Refs PY-2798
Refs #7566

Remove the legacy `send_default_pii` fallback branches and always
gate `http.query`, `url.path`, `url.full` and `client.address` on
`data_collection`.

Refs PY-2798
Refs #7566
@ericapisani
ericapisani added this pull request to stack #7770 September 29, 2026 17:25
@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

PY-2798

@ericapisani
ericapisani removed this pull request from stack #7770 September 29, 2026 17:26
@ericapisani
ericapisani added this pull request to stack #7771 September 29, 2026 17:26
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58513 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 61241 | Pass Rate: 95.55% | Execution Time: 165m 16s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -78772
Passed Tests 📉 -74280
Failed Tests 📈 +1
Skipped Tests 📉 -4493

➕ New Tests (1)

View new tests
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.12-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2054 uncovered lines.
❌ Project coverage is 90.19%. Comparing base (72e8214) to head (54187bd).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.37%    90.19%    -0.18%
==========================================
  Files          199       183       -16
  Lines        26526     20930     -5596
  Branches      9866      7316     -2550
==========================================
+ Hits         23971     18876     -5095
- Misses        2555      2054      -501
- Partials      1495      1216      -279

Generated by Codecov Action

@ericapisani
ericapisani marked this pull request as ready for review September 29, 2026 17:55
@ericapisani
ericapisani requested a review from a team as a code owner September 29, 2026 17:55
@ericapisani
ericapisani merged commit b0fcd98 into major/3.0 Oct 1, 2026
145 of 147 checks passed
@ericapisani
ericapisani deleted the py-2798-update-asgi-get-request-attributes branch October 1, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants