Skip to content

feat(boto3): align span names with OTel conventions - #7800

Merged
pabloDeputter merged 1 commit into
major/3.0from
pablo/boto3-service-id-span-names
Oct 1, 2026
Merged

pabloDeputter merged 1 commit into
major/3.0from
pablo/boto3-service-id-span-names

Conversation

@pabloDeputter

@pabloDeputter pabloDeputter commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Description

Align span names with OTel conventions:

Span name MUST be of the format Service.Operation as per the AWS HTTP API, e.g., DynamoDB.GetItem, S3.ListBuckets. This is equivalent to concatenating rpc.service and rpc.method with . and consistent with the naming guidelines for RPC client spans.

So we use modeled ServiceID and operation for span names: aws.<hyphenized-service-id>.<Operation> to <ServiceID>.<Operation>; e.g. aws.s3.GetObject => S3.GetObject.

(to be merged into the major branch)

Issues

Resolves #7498

@pabloDeputter
pabloDeputter changed the base branch from master to major/3.0 October 1, 2026 08:50
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58226 passed | ⏭️ 2727 skipped | Total: 60953 | Pass Rate: 95.53% | Execution Time: 163m 31s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -74457
Passed Tests 📉 -70593
Failed Tests 📉 -1
Skipped Tests 📉 -3863

➖ Removed Tests (1)

View removed tests
  • test_input_attributes_nonstreaming_chat[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
    • File: tests.integrations.mistral.test_mistral

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2056 uncovered lines.
❌ Project coverage is 90.15%. Comparing base (703493d) to head (ea40d98).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.37%    90.15%    -0.22%
==========================================
  Files          199       185       -14
  Lines        26526     20876     -5650
  Branches      9866      7260     -2606
==========================================
+ Hits         23971     18820     -5151
- Misses        2555      2056      -499
- Partials      1495      1206      -289

Generated by Codecov Action

@pabloDeputter
pabloDeputter changed the base branch from major/3.0 to master October 1, 2026 09:30
@pabloDeputter
pabloDeputter changed the base branch from master to major/3.0 October 1, 2026 11:10
@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-service-id-span-names branch from 0d1a29c to 19ba0c8 Compare October 1, 2026 11:22
@pabloDeputter
pabloDeputter marked this pull request as ready for review October 1, 2026 11:29
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 1, 2026 11:29
@pabloDeputter
pabloDeputter marked this pull request as draft October 1, 2026 11:48
@pabloDeputter

Copy link
Copy Markdown
Member Author

convert to draft since last PR of stack didn't merge for some reason

- use modeled `ServiceID` and operation for span names: `aws.<hyphenized-service-id>.<Operation>` to `<ServiceID>.<Operation>`; e.g. `aws.s3.GetObject` => `S3.GetObject`
@pabloDeputter
pabloDeputter force-pushed the pablo/boto3-service-id-span-names branch from 19ba0c8 to ea40d98 Compare October 1, 2026 13:41
@pabloDeputter
pabloDeputter marked this pull request as ready for review October 1, 2026 14:32
@pabloDeputter
pabloDeputter merged commit 6cbc1fd into major/3.0 Oct 1, 2026
147 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/boto3-service-id-span-names branch October 1, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(boto3): Use OTel AWS span naming

2 participants