Skip to content

ref(asgi): Deduplicate by removing _get_transaction_name_and_source() - #7813

Merged
alexander-alderman-webb merged 1 commit into
major/3.0from
webb/asgi/deduplicate
Oct 1, 2026
Merged

alexander-alderman-webb merged 1 commit into
major/3.0from
webb/asgi/deduplicate

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 1, 2026 11:45
@alexander-alderman-webb alexander-alderman-webb changed the title ref(asgi): Deduplicate by removing _get_transaction_name_and_source() ref(asgi): Deduplicate by removing _get_transaction_name_and_source() Oct 1, 2026

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58470 passed | ❌ 2 failed | ⏭️ 2727 skipped | Total: 61199 | Pass Rate: 95.54% | Execution Time: 163m 8s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -75857
Passed Tests 📉 -71364
Failed Tests —
Skipped Tests 📉 -4493

➕ New Tests (2)

View new tests
  • test_cache_spans_templatetag
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_async_transport_rate_limiting_with_concurrency
    • File: tests.test_transport
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_cache_spans_templatetag

File: tests.integrations.django.test_cache_module
Suite: py3.14t-django-v6.1.1
Error: tests/integrations/django/test_cache_module.py:362: in test_cache_spans_templatetag assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:362: in test_cache_spans_templatetag
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_async_transport_rate_limiting_with_concurrency

File: tests.test_transport
Suite: py3.8-common
Error: AssertionError: assert False is True + where False = _check_disabled('error') + where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f5678146370>._check_disabled + where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f5678146370> = <sentry_sdk.client._Client object at 0x7f56781232e0>.transport

Stack Trace
tests/test_transport.py:1037: in test_async_transport_rate_limiting_with_concurrency
    assert client.transport._check_disabled("error") is True
E   AssertionError: assert False is True
E    +  where False = _check_disabled('error')
E    +    where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f5678146370>._check_disabled
E    +      where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f5678146370> = <sentry_sdk.client._Client object at 0x7f56781232e0>.transport

✅ Patch coverage is 100.00%. Project has 2055 uncovered lines.
❌ Project coverage is 90.2%. Comparing base (3edb74f) to head (340b5a8).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.34%    90.20%    -0.14%
==========================================
  Files          199       183       -16
  Lines        26524     20974     -5550
  Branches      9864      7342     -2522
==========================================
+ Hits         23962     18919     -5043
- Misses        2562      2055      -507
- Partials      1495      1217      -278

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 95a6e92 into major/3.0 Oct 1, 2026
144 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/asgi/deduplicate branch October 1, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants