Skip to content

chore(core): resolve stale TODO comments #6819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
Oct 1, 2026
Merged

chore(core): resolve stale TODO comments #6819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/core/ios/RNSentry.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,6 @@ - (void)handleShakeDetected
NSLog(@"Bridge call to: deviceContexts");
}
__block NSMutableDictionary<NSString *, id> *serializedScope;
// Temp work around until sorted out this API in sentry-cocoa.
// TODO: If the callback isnt' executed the promise wouldn't be resolved.
[SentrySDKWrapper configureScope:^(SentryScope *_Nonnull scope) {
serializedScope = [[scope serialize] mutableCopy];

Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/js/tracing/reactnativenavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export const reactNativeNavigationIntegration = ({
latestNavigationSpan.updateName(event.componentName);
}
latestNavigationSpan.setAttributes({
// TODO: Should we include pass props? I don't know exactly what it contains, cant find it in the RNavigation docs
// `passProps` is intentionally omitted: arbitrary app data (potential PII); gate on `sendDefaultPii` if ever added.
'route.name': event.componentName,
'route.component_id': event.componentId,
'route.component_type': event.componentType,
Expand Down Expand Up @@ -227,7 +227,7 @@ export const reactNativeNavigationIntegration = ({
if (isSentrySpan(latestNavigationSpan)) {
markRootSpanForDiscard(latestNavigationSpan, 'discarded_latest_navigation');
}
// TODO: What if it's not SentrySpan?
// A non-SentrySpan here is a non-recording span whose end() is a no-op, so nothing to discard.
latestNavigationSpan.end();
latestNavigationSpan = undefined;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/js/tracing/reactnavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ export const reactNavigationIntegration = ({
if (isSentrySpan(latestNavigationSpan)) {
markRootSpanForDiscard(latestNavigationSpan, 'discarded_latest_navigation');
}
// TODO: What if it's not SentrySpan?
// A non-SentrySpan here is a non-recording span whose end() is a no-op, so nothing to discard.
latestNavigationSpan.end();
latestNavigationSpan = undefined;
}
Expand Down
Loading