Skip to content

chore(core): Resolve non-actionable TODOs #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
Oct 2, 2026
Merged

chore(core): Resolve non-actionable TODOs #6826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/core/ios/RNSentryNativeLogsForwarder.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,8 @@ - (void)stopForwarding
{
self.eventEmitter = nil;

// TODO: Ideally we should save the previous output block in configureWithEventEmitter:
// and restore it here instead of hardcoding NSLog.
// Reset to default print behavior
// cocoa exposes no public getter for the current SentrySDKLog output, so we reset to the
// default NSLog print behavior rather than restoring the previous block.
[SentrySDKLog setOutput:^(NSString *_Nonnull message) { NSLog(@"%@", message); }];
}

Expand Down
1 change: 0 additions & 1 deletion packages/core/src/js/tools/sentryMetroSerializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export function unstableBeforeAssetSerializationDebugIdPlugin({
return prependModule(premodules, debugIdModule);
}

// TODO: deprecate this and afterwards rename to createSentryDebugIdSerializer
/**
* Creates a Metro serializer that adds Debug ID module to the plain bundle.
* The Debug ID module is a virtual module that provides a debug ID in runtime.
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/js/transports/native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ export class NativeTransport implements Transport {
* @param envelope Envelope that should be sent to Sentry.
*/
public send(envelope: Envelope): PromiseLike<TransportMakeRequestResponse> {
// TODO: We currently can't retrieve the response information from native
// The native SDK owns the transport and doesn't expose the HTTP response, so there's
// no response info to return.
return this._buffer.add(() => NATIVE.sendEnvelope(envelope)).then(() => ({}));
}

Expand Down
Loading