Conversation
The Android SDK reports the generation of the cellular network technology in device.connection_effective_type from sentry-java 8.60.0. The field reaches events through serializeScope, so this SDK only has to bundle that version. iOS already reports the field, because sentry-cocoa 9.30.0 puts it into the extra context that fetchNativeDeviceContexts merges into the device context. The tests guard the path from the native layer to the event. The version bump follows when sentry-java 8.60.0 is released. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
|
|
@antonis this one is practically ready and will work automatically once Android releases a new version (iOS released it already). I wonder what you think of this PR — there is really no work needs to be done on our side (except for a test), and I feel like we could either merge this now or wait until the next Android release. Wdyt? |
antonis
left a comment
There was a problem hiding this comment.
LGTM 🎉
Happy to approve and leave the merge to you.
I would advocate on keeping this unmerged to test on a device after the Android bump and avoid unnecessary reverts if our 8.30.0 ships before Android 8.60.0 is available.
📢 Type of change
📜 Description
Events now report the generation of the cellular network technology in
device.connection_effective_type, for example4gor5g.Both native SDKs produce the field, so this SDK only has to pass it on. iOS already does, because sentry-cocoa 9.30.0 puts
connection_typeandconnection_effective_typeinto the extra context thatfetchNativeDeviceContextsmerges into the device context. Android needs sentry-java 8.60.0, whereDeviceInfoUtilsets both fields andserializeScopereturns them.The Android version bump is still missing, because sentry-java 8.60.0 is not released yet. This pull request stays a draft until the bump is in.
💡 Motivation and Context
Closes #4256
💚 How did you test it?
devicecontext.test.tsmakes sure that both fields reach the event device context from the native layer.📝 Checklist
sendDefaultPIIis enabled.