Disable Go module cache in goreleaser check job - #60
Merged
Merged
Conversation
The job only runs goreleaser check, which validates .goreleaser.yaml and builds nothing, so the cache saves no time while leaving the module cache writable from a job running goreleaser-action. release.yml already passes cache: false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zizmor reports a high-confidence
cache-poisoningfinding on thesetup-gostep in thegoreleaser-checkjob inci.yml: omittingcacheleaves module caching enabled in a job that runsgoreleaser-action.The job only runs
goreleaser check, which parses.goreleaser.yamland builds nothing, so the cache saves no time there.release.ymlalready passescache: falseto the same action.zizmor .github/workflows/reports no findings after the change.