(15) dpdk: typed flow rules

[daniel-noland]

Add typed flow builders for ingress, egress and transfer domains, with header matches, rewrite actions, VLAN actions and VXLAN encapsulation. Rule handles borrow their started device; stopping the port flushes remaining rules.

VXLAN encapsulation owns typed headers and borrows them through temporary FFI descriptors during validation and creation. Moving the builder no longer invalidates cached self-references.

Validation: 151 unit tests, one integration test and 24 doctests pass (two ignored); Clippy passes with warnings denied. The new move/reallocation regression also passes Miri using the actual lowering code extracted into an isolated harness with generated DPDK bindings.

Outstanding review items, deferred while earlier stack reviews are addressed:

• VLAN push/VID/PCP ordering: expose a combined push operation and keep its generated actions together. mlx5 requires PCP configuration after PUSH in the same action list; the current rank sort reverses them.
• Match and action typestate: distinguish the original matching pattern from the packet shape after mutations. The current builder cannot continue into inner VXLAN headers. BlueField-3 tests with DPDK 26.07, dv_flow_en=1 and firmware 32.50.1002 confirm inner matching works before decap, direct inner IPv4 rewriting is rejected, and decap followed by rewriting changes the exposed inner address. The broader API design remains open.
• Fallible destruction: failed explicit destroy currently loses the handle, and Drop only logs failure. Decide who retains failed rules and what teardown policy applies; a local table flush would invalidate other live handles.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[daniel-noland]

drop comment

[codecov]

Codecov Report

❌ Patch coverage is 35.04493% with 506 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
dpdk/src/flow/builder.rs	51.07%	250 Missing and 1 partial ⚠️
dpdk/src/flow/pattern.rs	0.00%	181 Missing ⚠️
dpdk/src/flow/rule.rs	0.00%	34 Missing ⚠️
dpdk/src/dev.rs	37.03%	15 Missing and 2 partials ⚠️
dpdk/src/flow/error.rs	0.00%	17 Missing ⚠️
dpdk/src/flow/mod.rs	0.00%	6 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Copilot review overview

🟡 Changes recommended

Flow destruction can lose live handles, mlx5 actions are reordered incorrectly, and inner VXLAN patterns cannot be constructed.

Review effort: Balanced
Findings: 3

Open (3)

• Correct mlx5 action ranking to match PMD order · New
• Return VXLAN builder at inner start position · New
• Preserve rule ownership when rte_flow_destroy fails · New

What changed in this PR

Replaces the previous flow API with typed DPDK flow construction, lowering, error handling, and RAII-managed rules.

Changes:

• Adds typestate-based flow domains and protocol ordering.
• Adds typed match/action lowering, including VLAN and VXLAN support.
• Adds structured PMD errors and automatic rule destruction.

File	Description
dpdk/​src/​flow/​mod.rs	Defines and exports the typed flow API.
dpdk/​src/​flow/​builder.rs	Builds, validates, and creates hardware flow rules.
dpdk/​src/​flow/​pattern.rs	Lowers typed match criteria into DPDK structures.
dpdk/​src/​flow/​error.rs	Classifies PMD flow errors.
dpdk/​src/​flow/​rule.rs	Manages installed rules through an RAII handle.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.