[GHSA-3cgp-3xvw-98x8] React Router has XSS Vulnerability - #9370
Open
HF-CYGG wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hi there @brophdawg11! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
github-actions
Bot
changed the base branch from
main
to
HF-CYGG/advisory-improvement-9370
September 5, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Add the upstream fix commit for this advisory.
The commit directly addresses the vulnerability described in
GHSA-3cgp-3xvw-98x8 by escaping JSON-LD content rendered by the
component before it is passed to dangerouslySetInnerHTML.
The commit changes the JSON-LD output from:
dangerouslySetInnerHTML={{ __html: json }}
to:
dangerouslySetInnerHTML={{ __html: escapeHtml(json) }}
and adds a regression test verifying that HTML-sensitive characters
in JSON-LD content are escaped.
The fix was merged in upstream PR #14316 and is included in
react-router 7.9.0, which is the patched version already recorded by
this advisory.
Upstream PR:
remix-run/react-router#14316
Fix commit:
remix-run/react-router@0e77485
React Router 7.9.0 release:
https://github.com/remix-run/react-router/releases/tag/react-router%407.9.0
No other advisory metadata is changed.