Skip to content

Fix npm dependency vulnerabilities - #126

Merged
manuelpuyol merged 1 commit into
mainfrom
manuelpuyol-fix-dependency-vulnerabilities
Sep 11, 2026
Merged

manuelpuyol merged 1 commit into
mainfrom
manuelpuyol-fix-dependency-vulnerabilities

Conversation

@manuelpuyol

Copy link
Copy Markdown
Contributor

Summary

  • upgrade @web/test-runner from ^0.20.0 to ^1.0.0, pulling in the patched Chrome runner and Puppeteer dependency chain
  • remove the vulnerable extract-zip path by upgrading to @puppeteer/browsers 3.x
  • update vulnerable transitive dependencies to patched releases: js-yaml 4.3.2, nanoid 3.3.18, and qs 6.16.0

Advisories fixed

  • extract-zip symlink path traversal/arbitrary file write (GHSA-jmr9-qjv8-65gv, GHSA-7pqw-9j4j-h8q3)
  • js-yaml merge-key CPU denial of service (GHSA-2883-xcg3-v3hh)
  • nanoid infinite-loop/integer overflow advisories (GHSA-28wg-ghj8-5hjv, GHSA-2v37-7h3g-55p8, GHSA-xwg4-73v4-xw9w)
  • qs denial-of-service advisories (GHSA-x5fp-wj9c-mxmx, GHSA-4mjr-xmp4-gh2g)

Validation

  • npm ci --registry=https://registry.npmjs.org/
  • CI=true npm test
  • npm run build
  • npm audit --json — 0 vulnerabilities

Upgrade Web Test Runner and refresh vulnerable transitive dependencies to patched releases.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 11, 2026 16:57
@manuelpuyol
manuelpuyol requested a review from a team as a code owner September 11, 2026 16:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Node setup is incompatible with the upgraded toolchain, and lockfile integrity hashes were weakened to SHA-1.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 High severity

New issues introduced by this change (1)
Severity Finding
High severity package.json — Align the repository setup action with the new Node requirement View comment
What changed in this PR

Upgrades the browser test toolchain and patches vulnerable transitive dependencies.

Changes:

  • Upgrades @web/test-runner to 1.x.
  • Updates Puppeteer and vulnerable transitive packages.
File Description
package.json Upgrades the test runner.
package-lock.json Refreshes the dependency graph and patched versions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
"@typescript-eslint/parser": "^6.5.0",
"@web/dev-server-esbuild": "^1.0.4",
"@web/test-runner": "^0.20.0",
"@web/test-runner": "^1.0.0",
@manuelpuyol
manuelpuyol merged commit 3840859 into main Sep 11, 2026
7 checks passed
@manuelpuyol
manuelpuyol deleted the manuelpuyol-fix-dependency-vulnerabilities branch September 11, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants