Python: Output JSON from tsg-python - #22527
Open
tausbn wants to merge 2 commits into
Open
Conversation
Changes the current text-based dump of the tsg-python graph to the native JSON output that tree-sitter-graph provides. This saves us the hassle of parsing the output ourselves, including the recently added bug fix that allowed us to interpret Rust-style string escapes in Python. As an added bonus, relying on the json module instead of our own parser roughly cuts the AST reconstruction time in half compared to previously, an extraction speedup in the neighbourhood of 3-4% (when tested on an extraction of `python/cpython` using only the tsg-python parser).
Contributor
Author
Rerun has been triggered: 6 restarted 🚀 |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The updated parser test fails independently because unittest.mock is not explicitly imported.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
python/extractor/tests/test_tsg_parser.py — Importing unittest alone does not load its mock submodule, so the new test raises… |
What changed in this PR
Switches tsg-python graph interchange from custom text parsing to native JSON serialization.
Changes:
- Serializes TSG graphs with
serde_json. - Decodes typed graph values in Python.
- Updates dependencies, tests, and extractor version.
| File | Description |
|---|---|
MODULE.bazel |
Registers the JSON dependency. |
misc/bazel/3rdparty/py_deps/BUILD.bazel |
Adds dependency aliases. |
misc/bazel/3rdparty/py_deps/defs.bzl |
Configures the vendored crate. |
python/extractor/semmle/python/parser/tsg_parser.py |
Replaces text parsing with JSON decoding. |
python/extractor/semmle/util.py |
Bumps the extractor version. |
python/extractor/tests/test_tsg_parser.py |
Tests JSON graph decoding. |
python/extractor/tsg-python/Cargo.lock |
Locks the direct JSON dependency. |
python/extractor/tsg-python/Cargo.toml |
Declares serde_json. |
python/extractor/tsg-python/src/main.rs |
Emits the graph as JSON. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: tausbn <1104778+tausbn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the current text-based dump of the
tsg-pythongraph to the native JSON output thattree-sitter-graphprovides. This saves us the hassle of parsing the output ourselves, including the recently added bug fix that allowed us to interpret Rust-style string escapes in Python.As an added bonus, relying on the
jsonmodule instead of our own parser roughly cuts the AST reconstruction time in half compared to previously, an extraction speedup in the neighbourhood of 3-4% (when tested on an extraction ofpython/cpythonusing only thetsg-pythonparser).