C#: Rename Dependabot to Registry and update log messages. - #22542
Open
michaelnebel wants to merge 2 commits into
Open
C#: Rename Dependabot to Registry and update log messages.#22542michaelnebel wants to merge 2 commits into
michaelnebel wants to merge 2 commits into
Conversation
michaelnebel
changed the title
michaelnebel
force-pushed
the
csharp/dependabottoregistryrename
branch
from
September 10, 2026 13:40
fc5a547 to
67f98aa
Compare
michaelnebel
force-pushed
the
csharp/dependabottoregistryrename
branch
from
September 11, 2026 09:51
67f98aa to
1c2025b
Compare
…mprove some unit tests comments.
michaelnebel
force-pushed
the
csharp/dependabottoregistryrename
branch
from
September 11, 2026 09:58
1c2025b to
c5d5827
Compare
michaelnebel
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The rename is complete and consistent; the identified documentation wording issue is non-blocking.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/EnvironmentVariableNames.cs — Describe ProxyPort as a port |
What changed in this PR
Renames the C# dependency-fetching proxy abstraction from Dependabot to Registry and updates related logging and tests.
Changes:
- Renames proxy interfaces, implementations, parameters, and test stubs.
- Updates proxy log messages and certificate directory naming.
- Clarifies unit-test comments.
| File | Description |
|---|---|
RegistryProxy.cs (tests) |
Renames proxy tests and stubs. |
FeedManager.cs (tests) |
Updates test proxy names and comments. |
RegistryProxyConfiguration.cs |
Renames configuration implementation. |
RegistryProxy.cs |
Renames proxy implementation and messages. |
NugetPackageRestorer.cs |
Uses the renamed proxy interface. |
IRegistryProxyConfiguration.cs |
Renames the configuration interface. |
IRegistryProxy.cs |
Renames the proxy interface. |
FeedManagerIO.cs |
Updates proxy handling and warnings. |
FeedManager.cs |
Updates proxy constructor parameters. |
EnvironmentVariableNames.cs |
Updates proxy documentation. |
DotNetCliInvoker.cs |
Updates proxy parameter and logging. |
DotNet.cs |
Propagates the renamed proxy type. |
DependencyManager.cs |
Creates, passes, and disposes the renamed proxy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mbg
approved these changes
Sep 11, 2026
mbg
left a comment
mbg
left a comment
Member
There was a problem hiding this comment.
Thanks for remembering! This generally looks good to me, with just one minor nitpicky comment about the capitalisation of "Registry proxy".
| if (this.proxy != null) | ||
| { | ||
| logger.LogDebug($"Configuring environment variables for the Dependabot proxy at {this.proxy.Address}"); | ||
| logger.LogDebug($"Configuring environment variables for the Registry proxy at {this.proxy.Address}"); |
Member
There was a problem hiding this comment.
Minor: Use lower-case registry proxy instead of Registry proxy in log messages, comments, etc. when it doesn't appear at the start of a sentence since unlike "Dependabot", "Registry" is not a product name and so shouldn't be capitalised.
| ? "chain" | ||
| : "certificate"; | ||
| logger.LogWarning($"Dependabot proxy certificate validation failed due to missing {msg}"); | ||
| logger.LogWarning($"Registry proxy certificate validation failed due to missing {msg}"); |
Member
There was a problem hiding this comment.
(Here the upper-case "Registry" is fine since it's at the start of a sentence.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also slightly improve some unit test comments.