Unified: Stats for type mentions - #22710
Merged
Merged
Conversation
hvitved
force-pushed
the
unified/type-mention-stats
branch
from
September 30, 2026 11:38
20a63fa to
a5ea635
Compare
hvitved
marked this pull request as ready for review
September 30, 2026 15:20
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused telemetry addition is consistent with existing analysis-quality reporting patterns and has no identified correctness issues.
Review effort: Balanced
Findings: None
What changed in this PR
Adds telemetry measuring how effectively Unified resolves expression-based type mentions.
Changes:
- Exposes type-mention classes for statistics collection.
- Reports resolved, unresolved, and percentage-resolved type mentions.
- Includes these metrics in extractor information.
| File | Description |
|---|---|
unified/ql/src/diagnostic/ExtractorInformation.ql |
Emits type-mention statistics. |
unified/ql/lib/codeql/unified/internal/typeinference/TypeMention.qll |
Exposes type-mention class aliases. |
unified/ql/lib/codeql/unified/internal/AnalysisQuality.qll |
Defines type-mention resolution statistics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
asgerf
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.