Unified: Extract Swift in-out expressions and postfix operators - #22712
Merged
Merged
Conversation
These are handled exactly like prefix operators.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The translation rules match the Swift syntax schema and are covered by appropriate corpus and control-flow expectations.
Review effort: Balanced
Findings: None
What changed in this PR
Adds unified Swift AST extraction for in-out expressions and postfix operators.
Changes:
- Maps both node kinds to unary expressions with correct operator fixity.
- Updates corpus and control-flow expectations.
| File | Description |
|---|---|
unified/extractor/src/languages/swift/swift.rs |
Adds Swift translation rules. |
unified/extractor/tests/corpus/swift/functions/call-with-inout-argument.output |
Updates in-out extraction expectation. |
unified/extractor/tests/corpus/swift/operators/custom-postfix-operator.output |
Updates custom postfix expectation. |
unified/extractor/tests/corpus/swift/operators/partial-range-from.output |
Updates range operator expectation. |
unified/ql/test/library-tests/controlflow/basicblock-slices.expected |
Updates control-flow output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extraction of two trivial Swift node kinds: In-out expressions (
&expr) and postfix operators (handled like prefix operators).