Repository navigation
Rust: Improvements to the rust-analyzer update workflow - #22769
Merged
Merged
Conversation
Previously we assumed that the release date of a rust-analyzer crate would match a git tag. However, these dates may not line up exactly which we now handle.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes consistently address both documented workflow failures without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Improves rust-analyzer updates by resolving the appropriate release tag and ensuring CodeQL is available.
Changes:
- Selects the latest compatible dated rust-analyzer tag, including suffixed tags.
- Separates tag resolution, archive integrity calculation, and source updates.
- Adds CodeQL setup to the generated workflow.
| File | Description |
|---|---|
rust/scripts/update_rust_analyzer.py |
Resolves release tags and updates source/toolchain metadata. |
.github/workflows/update-rust-analyzer.md |
Adds CodeQL setup. |
.github/workflows/update-rust-analyzer.lock.yml |
Regenerates the compiled workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
andersfugmann
previously approved these changes
Oct 8, 2026
andersfugmann
left a comment
andersfugmann
left a comment
Contributor
There was a problem hiding this comment.
Apart from one Nit (feel free to ignore) LGTM
| def get_compatible_rust_toolchain(rust_analyzer_release_tag: str) -> str: | ||
| """Get the latest Rust toolchain released no later than rust-analyzer.""" | ||
| rust_analyzer_release = get_rust_analyzer_release_date(rust_analyzer_version) | ||
| rust_analyzer_release = rust_analyzer_release_tag[:10] |
Contributor
There was a problem hiding this comment.
Would be helpful to comment exptected format of rust_analyzer_release_tag parameter to make it clear that the first 10 chars is a date on the form YYYY-MM-DD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two minor fixes to the rust-analyzer update script:
codeqlCLI is available in the workflow