Skip to content

Run Node CI for pull requests - #105

Merged
liuliu-dev merged 1 commit into
mainfrom
enable-pull-request-ci
Oct 15, 2026
Merged

liuliu-dev merged 1 commit into
mainfrom
enable-pull-request-ci

Conversation

@liuliu-dev

Copy link
Copy Markdown
Contributor

The Node CI workflow currently runs only on push, so pull requests from forks never receive the expected build and test check and remain pending.

Run the workflow for pull_request events as well so contributor PRs are validated before merge.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@liuliu-dev
liuliu-dev requested a review from a team as a code owner October 15, 2026 21:08
Copilot AI max review requested due to automatic review settings October 15, 2026 21:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The trigger change meets the stated goal without changing job behavior or read-only permissions.

0 open findings

What changed in this PR

Enables fork pull requests to receive the existing Node build and test checks before merging.

Changes:

  • Adds the pull_request trigger while preserving CI on pushes.
File Description
.github/​workflows/​nodejs.yml Enables the existing Node CI workflow for pull requests.

🧠 Review effort: Max


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@liuliu-dev
liuliu-dev merged commit c2aeb37 into main Oct 15, 2026
8 checks passed
@liuliu-dev
liuliu-dev deleted the enable-pull-request-ci branch October 15, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants