Skip to content

chore: upgrade bug-fix and bug-test to gh-aw v0.88.7 - #4604

Open
KSchlobohm wants to merge 4 commits into
github:mainfrom
KSchlobohm:kschlobohm-sep-15-bug-workflows
Open

KSchlobohm wants to merge 4 commits into
github:mainfrom
KSchlobohm:kschlobohm-sep-15-bug-workflows

Conversation

@KSchlobohm

@KSchlobohm KSchlobohm commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description

Upgrade bug-fix and bug-test together from gh-aw v0.79.8 / Copilot 1.0.60 to gh-aw v0.88.7 / Copilot 1.0.80, following #4546.

  • Regenerate both workflow locks with authenticated immutable action resolution and --strict --validate.
  • Preserve bug-test's editable installation with test extras while avoiding the compiler's local-path package-validation error.
  • Allow github.com explicitly for origin fetches. Clarify that failed discovery or checkout is a setup failure, not evidence that no fix exists, and require original exit codes before output filtering.
  • Add focused positive and negative regression coverage.

Source-level label gates, bot exclusions, permissions, allowed outputs, and output limits are preserved. This intentionally accepts the new compiler defaults: a 4 MB patch limit instead of 1 MB, and protected-file checks that retain Copilot instruction files but no longer include CLAUDE.md or GEMINI.md.

The diff contains only both generated locks, bug-test.md, and tests/test_github_workflows.py. No community workflows, shared action pins, test fixtures, or generated product fixes are included.

Testing

  • Tested locally with uv run specify --help
  • Ran focused existing and new workflow tests using this worktree's own virtual environment.
  • Tested with a sample project (if applicable)

Local validation:

  • Workflow tests: 18 passed, 7 Bash-dependent cases skipped on Windows.
  • Separately executed all four installer cases with native Git Bash; all passed, covering editable installation, test extras, and failure propagation.
  • Ruff and git diff --check passed.
  • Both strict compilations reproduced the generated locks exactly.
  • Both workflow sources and locks match the fork-tested versions.

Applicable CI passed on the final fork upgrade and reliability PRs, including Linux, Windows, and macOS with Python 3.13 and 3.14.

Fork testing provided evidence that the upgraded workflows work together in practice—not just that they compile—and that test results reflect the proposed fix rather than the wrong checkout. The end-to-end run supports that conclusion, but also exposed instruction-following deviations; it does not establish complete workflow-contract compliance. Three broader-suite failures also reproduced on the base checkout.

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

GitHub Copilot (GPT-6 Astra) prepared the workflow changes, regression tests, validation, and this description on behalf of @KSchlobohm. The human contributor directed scope and approved fork publication and controlled test runs. Agent-authored commits include attribution. Fork runtime behavior was checked against logs and GitHub state.

KSchlobohm and others added 3 commits September 15, 2026 18:47
Regenerate bug-fix and bug-test with Copilot 1.0.80. Preserve the 1 MB patch limit and editable Python test extras through the local-package validation workaround. Add focused workflow contract regressions.

Accept the v0.88.7 Copilot-specific protected-file set: CLAUDE.md and GEMINI.md are no longer hard-blocked. This exception was approved by the user.

Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the 1 MB compatibility override and its regression assertions. Let gh-aw v0.88.7 supply its default 4 MB patch limit without adding a repository-specific restriction. Regenerate the lock with the approved compiler.

Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Allow github.com for origin Git access. Require successful discovery before using the current-checkout fallback, report discovery or checkout errors as setup failures, and require original exit codes before output filtering. Include focused regressions without a standalone shell recipe.

These instructions do not guarantee agent compliance. Fork tests demonstrated Git access and exact-head handoff; inconsistent exit capture and other observed runtime limitations remain documented in the review evidence.

Assisted-by: GitHub Copilot (model: GPT-6 Astra, autonomous)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 15, 2026 23:56
@KSchlobohm
KSchlobohm marked this pull request as ready for review September 15, 2026 23:57
@KSchlobohm
KSchlobohm requested a review from mnriem as a code owner September 15, 2026 23:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The intentional 4 MB patch limit is not protected by the new regression tests.

Get a fresh assessment by requesting another Copilot review.

Review tier: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Upgrades the bug-fix and bug-test automation to gh-aw v0.88.7 and Copilot 1.0.80 while preserving workflow contracts.

Changes:

  • Regenerates both workflow locks.
  • Hardens bug-test checkout and exit-code handling.
  • Adds regression coverage for workflow contracts and installation failures.
File Description
.github/​workflows/​bug-fix.lock.yml Regenerates bug-fix with upgraded runtime.
.github/​workflows/​bug-test.md Updates networking, installation, and failure guidance.
.github/​workflows/​bug-test.lock.yml Regenerates bug-test with upgraded runtime.
tests/​test_github_workflows.py Adds workflow contract and regression tests.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/test_github_workflows.py
Add assertion for maximum patch size in PR creation

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 16, 2026 00:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The large generated workflow changes affect privileged automation and warrant final human review despite strong regression and fork coverage.

Review tier: Balanced
Findings: None

Resolved since last review (1)

@mnriem mnriem added the triage-nice-to-have Verdict: evidence-backed fix or greenlit feature — land after review label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage-nice-to-have Verdict: evidence-backed fix or greenlit feature — land after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants