Remove the draft-to-ready CI workaround - #296
Open
henrymercer wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are small, consistent with the stated goal (avoid duplicate checks), and do not introduce new logic beyond adjusting PR creation and workflow triggers.
Review tier: Lite
Findings: None
What changed in this PR
Removes the draft→ready CI workaround for CodeQL submodule update PRs now that GITHUB_TOKEN-authored PRs can support the required check approval flow, which should eliminate duplicate workflow runs when drafts are marked ready.
Changes:
- Stop creating CodeQL submodule update PRs as drafts.
- Stop triggering the “Check submodule pointers” workflow on
ready_for_reviewto avoid duplicate runs.
| File | Description |
|---|---|
| .github/workflows/update-codeql-submodule.yml | Creates submodule update PRs as non-drafts (removes --draft). |
| .github/workflows/check-submodule-pointers.yml | Removes ready_for_review PR event trigger to prevent duplicate checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the draft-to-ready CI workaround now that
GITHUB_TOKENPRs support check approval, avoiding duplicate checks when drafts are marked ready.