refactor(compile): consolidate reviewed bot improvements - #2238
Merged
Merged
Conversation
…t job/stage Front matter parameters named dependsOn or condition on target: job or target: stage collide with the compiler's auto-injected template parameters and fail compilation, but this was undocumented in both docs/targets.md and docs/parameters.md. Add the compile-time error behavior to both pages, cross-linked. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…te-pull-request Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…log ado-proxy kind) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
resolve_audit_context / validate_audit_url_host stops `ado-aw audit <url>` from sending ADO credentials to an attacker-controlled or mismatched host, but every prior tests/audit_it.rs case only passed a bare numeric build ID. The guard itself was only exercised by unit tests calling the function directly, so a regression dropping the parsed.host wiring in resolve_audit_context would not be caught by any subprocess-level test. Add two subprocess tests that invoke the real ado-aw binary with a full build URL: - audit_rejects_untrusted_host_in_build_url_without_org_override: an attacker.example.com URL with no --org must fail with the PAT-exfiltration guard message. - audit_rejects_build_url_host_mismatched_with_trusted_org: an on-prem URL host that differs from a trusted --org host must still be refused. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…_config Splits the 135-line, cognitive-complexity-25 function into six focused helpers: - validate_create_github_issue_approval_lanes - validate_github_issue_shared_policy - validate_github_issue_tool_specific_config - validate_github_issue_tools - validate_create_github_issue_injection - validate_set_github_issue_type_injection validate_github_issue_outputs_config now just orchestrates these calls. No behaviour change; all existing tests pass unmodified. Highest remaining complexity among the extracted helpers is 13 (down from 25), and the orchestrator itself is no longer flagged even at a cognitive-complexity-threshold of 10. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Bumps [qs](https://github.com/ljharb/qs) from 6.15.2 to 6.16.0. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.15.2...v6.16.0) --- updated-dependencies: - dependency-name: qs dependency-version: 6.16.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@vitest/mocker](https://github.com/vitest-dev/vitest/tree/HEAD/packages/mocker) to 4.1.11 and updates ancestor dependency [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). These dependencies need to be updated together. Updates `@vitest/mocker` from 4.1.6 to 4.1.11 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.11/packages/mocker) Updates `vitest` from 4.1.6 to 4.1.11 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Changelog](https://github.com/vitest-dev/vitest/blob/main/docs/releases.md) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.1.11/packages/vitest) --- updated-dependencies: - dependency-name: "@vitest/mocker" dependency-version: 4.1.11 dependency-type: indirect - dependency-name: vitest dependency-version: 4.1.11 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [svgo](https://github.com/svg/svgo) from 4.0.2 to 4.1.0. - [Release notes](https://github.com/svg/svgo/releases) - [Commits](svg/svgo@v4.0.2...v4.1.0) --- updated-dependencies: - dependency-name: svgo dependency-version: 4.1.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sharp](https://github.com/lovell/sharp) from 0.35.3 to 0.35.4. - [Release notes](https://github.com/lovell/sharp/releases) - [Commits](lovell/sharp@v0.35.3...v0.35.4) --- updated-dependencies: - dependency-name: sharp dependency-version: 0.35.4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) from 7.1.3 to 7.3.2. - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/astro/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/astro@7.3.2/packages/astro) --- updated-dependencies: - dependency-name: astro dependency-version: 7.3.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [smol-toml](https://github.com/squirrelchat/smol-toml) from 1.6.1 to 1.8.0. - [Release notes](https://github.com/squirrelchat/smol-toml/releases) - [Commits](squirrelchat/smol-toml@v1.6.1...v1.8.0) --- updated-dependencies: - dependency-name: smol-toml dependency-version: 1.8.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [devalue](https://github.com/sveltejs/devalue) from 5.8.1 to 5.9.2. - [Release notes](https://github.com/sveltejs/devalue/releases) - [Changelog](https://github.com/sveltejs/devalue/blob/main/CHANGELOG.md) - [Commits](sveltejs/devalue@v5.8.1...v5.9.2) --- updated-dependencies: - dependency-name: devalue dependency-version: 5.9.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.28.4 to 4.28.8. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.28.4...4.28.8) --- updated-dependencies: - dependency-name: browserslist dependency-version: 4.28.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.10.38 to 2.11.21. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.10.38...v2.11.21) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.11.21 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps and [js-yaml](https://github.com/nodeca/js-yaml). These dependencies needed to be updated together. Updates `js-yaml` from 4.2.0 to 4.3.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.2/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.2.0...4.3.2) Updates `js-yaml` from 3.14.2 to 3.15.2 - [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.2/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.2.0...4.3.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.3.2 dependency-type: indirect - dependency-name: js-yaml dependency-version: 3.15.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aba7a965-412b-4f58-8d80-cf67bde7b0ce # Conflicts: # src/compile/common.rs
This was referenced Sep 24, 2026
This was referenced Sep 24, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates the second reviewed wave of bot-authored changes against
e2737db922906a3cc20ec011e2db17f0a5da176f(#2189), selecting one canonicalimplementation where pull requests overlap.
Integrated changes
MCP-author, and the ADO proxy smoke.
scripts/ado-script,site, andsite/slides.baseline-browser-mapping2.11.21.Dispositions
qs6.16.0.svgo4.1.0.baseline-browser-mapping2.11.21 retained with #2085.sharp0.35.4.js-yamlupdate.smol-toml1.8.0.dependsOnandconditiondocumentation.devalue5.9.2.container_runtime.rsarchitecture entry already merged in #2189.repositories:sample pattern and is not included.copilot-vendordocumentation already merged in #2189.container_runtime.rsarchitecture entry already merged in #2189.container_runtime.rsarchitecture entry already merged in #2189.Explicitly excluded and untouched:
No deferred pull request will be rejected or closed by this consolidation.
Validation
cargo test— passed, including 3,349 unit tests and all integration suites.cargo clippy --all-targets -- -D warnings— passed.cargo test test_validate_github_issue_outputs— 8 passed.cargo test --test audit_it— 7 passed.cargo test inspect::catalog— 8 passed.git diff --check— passed.This host could not execute clean npm installs because its configured Azure
Artifacts registry returned E401 and direct npm registry retries encountered
TLS/npm-client failures. The aggregate CI runs the authoritative clean
TypeScript and site installs/builds.