fix(ci): patch app-builder-lib keychain password for macOS signing - #3284
Merged
Conversation
github-actions
Bot
added
bug
afonsojramos
force-pushed
the
fix/gitify-publish-failure
branch
from
September 6, 2026 22:17
b2c0756 to
bbef29b
Compare
electron-builder 26.15.3 passes the .p12 import password to `security set-key-partition-list -k`, which expects the temporary keychain's own unlock password. Older macOS builds tolerated the mismatch because the keychain had just been unlocked; the macOS 26.6 runner image (macos-latest since 2026-09) validates it and fails with "SecKeychainUnlock: The user name or passphrase you entered is not correct", which broke the v7.8.0 macOS publish job. Apply the upstream fix (electron-userland/electron-builder#10101) as a pnpm patch until it ships in a 26.x release. Windows and Linux packaging do not touch this code path.
afonsojramos
force-pushed
the
fix/gitify-publish-failure
branch
from
September 6, 2026 22:18
bbef29b to
e0ed957
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v7.8.0 macOS publish job failed in electron-builder's temporary-keychain setup, before signing started:
Nothing changed on our side (no secrets, no workflow, no electron-builder version). The only difference from the v7.7.1 publish two days earlier is the
macos-latestrunner image:Root cause
electron-builder 26.15.3 passes the
.p12import password (CSC_KEY_PASSWORD) tosecurity set-key-partition-list -k, but that flag expects the temporary keychain's own randomly generated unlock password. Older macOS builds tolerated the mismatch because the keychain had just been unlocked; macOS 26.6 validates it and fails.Upstream: electron-userland/electron-builder#10066, fixed by electron-userland/electron-builder#10101 (merged 2026-08-27). The fix is not in any stable release yet, including 26.16.0 (see electron-userland/electron-builder#10167).
Change
app-builder-lib@26.15.3that mirrors PR #10101: passkeychainPasswordthrough toimportCertsand use it forset-key-partition-list -k.pnpm-workspace.yaml(with a comment on when to drop it) and record the patch hash inpnpm-lock.yaml.Windows and Linux packaging do not enter this code path.
Verification
pnpm install --frozen-lockfileapplies the patch; the installedmacCodeSign.jsin the pnpm store contains the fix.vp fmt --checkandvp lintpass.After merge
Run the Publish workflow via
workflow_dispatchonmainwithtag_name: v7.8.0. The v7.8.0 draft already exists with no assets; this will attach the signed artifacts, publish the release, and trigger the website deploy.Follow-up: once electron-builder ships a 26.x release containing #10101, bump it and remove
patches/app-builder-lib@26.15.3.patch.