Skip to content

test: sync record member keyword fixtures - #3121

Closed
mjq2020 wants to merge 1 commit into
glideapps:masterfrom
mjq2020:agent/sync-record-member-keywords
Closed

mjq2020 wants to merge 1 commit into
glideapps:masterfrom
mjq2020:agent/sync-record-member-keywords

Conversation

@mjq2020

@mjq2020 mjq2020 commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • add the C# record member names clone, equalityContract, and printMembers to test/keywords.txt
  • regenerate all three keyword fixtures with test/make-keyword-tests.sh
  • restore byte-for-byte reproducibility between the generator input and checked-in outputs

Root cause

PR #3078 added the three names directly to keywords.json, but not to the source list consumed by keywords.py. Running the documented generator therefore removed those cases. Adding them to keywords.txt keeps the JSON, enum schema, and union schema in sync. The small object-boundary reshuffle in keywords.json is expected because the generator splits the ordered list into groups of 64.

Tests

  • byte-for-byte regeneration check for all three generated files
  • npm run build
  • npm run test:unit (52 files, 236 tests)
  • npm run lint -- --no-errors-on-unmatched
  • focused keywords.json fixture tests for JavaScript, TypeScript, Python, PHP, and Go

Fixes #3120

@mjq2020
mjq2020 marked this pull request as ready for review August 14, 2026 01:43
@mjq2020

mjq2020 commented Sep 20, 2026

Copy link
Copy Markdown
Author

Closing this as superseded by #3473, which merged the same three missing C# record member names as part of a broader generator/fixture synchronization and resolved #3120. Thanks!

@mjq2020 mjq2020 closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: keywords.json deviated from generator file keywords.txt

1 participant