Repository navigation
Fix grp2idx empty output shape - #501
Merged
pr0m1th3as merged 2 commits intoSep 24, 2026
Merged
Conversation
sahilphad07-sudo
force-pushed
the
fix-grp2idx-empty-output
branch
from
September 20, 2026 17:28
1b0af91 to
5beba34
Compare
pr0m1th3as
added a commit
that referenced
this pull request
Sep 24, 2026
…low-up to #501. * inst/Data_Manipulation/grp2idx.m: take an empty cell array or string array, which failed on an undefined variable; return a 0-by-1 GL for an empty categorical, keeping GN 0-by-1 where MATLAB has it 0-by-0; say so in the help text; add tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grp2idx returned an incorrectly shaped output for empty numeric vectors. MATLAB returns an empty column vector with size 0x1, while Octave returned an empty 0x0 matrix. This happened because unique (s(:)) returns g with size 0x0 when the input is empty. Fixed by ensuring an empty g has size 0x1.
BEFORE:
AFTER:
MATLAB:
>> [g, gn, gl] = grp2idx(zeros(0, 1));
>> size(g)