Repository navigation
Fix rmmissing empty input validation - #502
Merged
pr0m1th3as merged 1 commit intoSep 24, 2026
Merged
Conversation
pr0m1th3as
added a commit
that referenced
this pull request
Sep 24, 2026
… follow-up to #502. * inst/Data_Manipulation/rmmissing.m: drop the early return for empty input, so TF has one element per row or column; accept MinNumMissing 0; count missing values per element on a vector, so a value above 1 removes nothing, as MATLAB does; update the help text; add tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rmmissingreturned early for empty inputs before validating optional arguments. As a result, invalidMinNumMissing,MissingLocations, andDIMvalues were silently accepted for empty inputs, unlike MATLAB.This change moves empty-input handling after argument validation so invalid arguments are rejected consistently.
Before
After
MATLAB Behavior
Regression Tests Added
MinNumMissingDIMMissingLocationsTest Results
All existing and new
rmmissingBISTs pass: