Fix datasample MATLAB compatibility - #505
Merged
pr0m1th3as merged 1 commit intoSep 24, 2026
Merged
Conversation
pr0m1th3as
added a commit
that referenced
this pull request
Sep 24, 2026
Elements sharing an Inf weight are equally likely, where MATLAB draws only the first of them; the help text says so. * inst/Data_Manipulation/datasample.m: validate the weights through one variable; reword the message to non-negative values with at least one positive; indent the sampling loop without replacement; describe zero and Inf weights in the help text; match every weights error in full; add tests for several Inf weights, with and without replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datasampledid not match MATLAB behavior for invalid and infinite sampling weights.NaN and all-zero weights were not rejected during validation, and
Infweights could lead to incorrect sampling because normalizing infinite values produced invalid probabilities.This change updates weight validation and sampling logic to handle these cases consistently with MATLAB.
Before
After
MATLAB Behavior
Infweight is always selected when sampling with replacement.Inf-weighted element is selected first.Regression Tests Added
Infweights with replacementInfweights without replacementTest Results
All existing and new
datasampleBISTs pass: