Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Friendly ping — this has been green and unreviewed for about a month. One clarification in case the bot comment above caused confusion: the CLA is signed — the The change adds a |
|
Closing this — it has been open since June with no review, and I would rather not leave a stale PR sitting in the queue. Happy to reopen if the version_file input is something you would like. |
Adds an optional
version_fileinput that resolves the Cloud SDK version from a file, mirroring the*-version-filepattern inactions/setup-go,actions/setup-node, andactions/setup-python.Two formats are supported:
416.0.0or>= 416.0.0).tool-versionsfile containing agcloud <version>linePrecedence: an explicitly set
version(anything other than the defaultlatest) wins andversion_fileis ignored with a warning. The version-resolution logic is unchanged once a concrete version is determined, so the existing install/cache path is reused as-is.Validation (run locally):
npm run lint(eslint) passesnpm testpasses, 22/22 (added 3run()cases for.tool-versions/ plain file /versionprecedence, plus 5parseVersionFileunit cases)npm run build(ncc) rebuiltdist/index.jsnpm run docsregenerated the README inputs section