Conversation
cjreynol
force-pushed
the
bootloader_specified
branch
from
September 29, 2026 00:08
737e69e to
6d27212
Compare
Required making the `FindAndroidBuilds` helper available for the `parsed_flags` logic to instantiate the `AndroidBuilds` object. Bug: 476231437
For the `bootloader_specified` metric field we need to be able to detect per-instance defaults for multi-device cases. Bug: 476232231
cjreynol
force-pushed
the
bootloader_specified
branch
from
September 29, 2026 18:43
6d27212 to
82eff01
Compare
cjreynol
commented
Sep 29, 2026
| AndroidBuilds android_builds = | ||
| CF_EXPECT(FindAndroidBuilds(system_image_dir, fetcher_configs)); | ||
|
|
||
| const BootImageFlag boot_image = |
Collaborator
Author
There was a problem hiding this comment.
Waiting on #3248 for this value to be available.
Bug: 476232231
cjreynol
force-pushed
the
bootloader_specified
branch
from
September 29, 2026 18:47
82eff01 to
b72394a
Compare
cjreynol
marked this pull request as ready for review
September 29, 2026 18:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: 476232231