Repository navigation
Report an error when AutoFactory implementing methods cannot match create(). - #2166
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…eate(). When an `@AutoFactory(implementing = …)` (or `extending`) abstract method has no matching factory `create` overload, AutoFactory used to emit a forwarding stub `return create(args)`. If that abstract method was itself named `create`, the stub called itself and threw `StackOverflowError` at runtime. The usual trigger is forgetting `@Provided` on a constructor parameter, which silently turns that parameter into an extra factory argument. Report a compile-time error that names the unmatched method and points at `@Provided`, instead of generating the recursive stub. Closes #697. Closes #2152. RELNOTES=AutoFactory now reports a compile-time error when an abstract method from an `implementing` or `extending` type does not match any generated factory method, instead of generating a method that fails to compile or calls itself recursively. PiperOrigin-RevId: 1000110875
copybara-service
Bot
force-pushed
the
test_1000110875
branch
from
October 16, 2026 19:33
5151ad7 to
6a11183
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report an error when AutoFactory implementing methods cannot match create().
When an
@AutoFactory(implementing = …)(orextending) abstract method has no matching factorycreateoverload, AutoFactory used to emit a forwarding stubreturn create(args). If that abstract method was itself namedcreate, the stub called itself and threwStackOverflowErrorat runtime. The usual trigger is forgetting@Providedon a constructor parameter, which silently turns that parameter into an extra factory argument.Report a compile-time error that names the unmatched method and points at
@Provided, instead of generating the recursive stub.Closes #697.
Closes #2152.
RELNOTES=AutoFactory now reports a compile-time error when an abstract method from an
implementingorextendingtype does not match any generated factory method, instead of generating a method that fails to compile or calls itself recursively.