Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4561 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 197 197
Lines 18299 18299
=======================================
Hits 18038 18038
Misses 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
|
@Not-Dhananjay-Mishra and @gmlewis it should be ready for approval now then :-) |
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
|
@Not-Dhananjay-Mishra and @gmlewis applied the second round of review file suggestions. |
gmlewis
left a comment
There was a problem hiding this comment.
Excellent, thank you, @Not-Dhananjay-Mishra and @devantler!
Sorry that I didn't provide helpful feedback right up front to save you a good deal of time, and thank you, @Not-Dhananjay-Mishra for guiding us here.
LGTM.
@Not-Dhananjay-Mishra - has all your feedback been addressed?
No worries, we all do this all the time 😃 I am happy we got it as we want it, as that is the important thing after all! |
|
This PR will be reviewed after we have gotten |
|
Thank you, @Not-Dhananjay-Mishra! |
Summary
CustomPropertycould not represent GitHub’s optionalrequire_explicit_valuessetting, preventing clients such as the Terraform provider from preserving or managing it.This adds the optional field, keeps omitted and explicit
falsevalues distinct, and covers response decoding plus batch and single-property request bodies.Closes #4559
Supersedes #4560 to resolve contributor CLA attribution.
Assisted contribution
GitHub Copilot substantially assisted with the code, tests, and prose. I reviewed, understood, and tested every change.