Skip to content

feat: Support explicit custom property values - #4561

Merged
gmlewis merged 5 commits into
google:masterfrom
devantler:devantler-explicit-custom-property-values-cla
Sep 17, 2026
Merged

gmlewis merged 5 commits into
google:masterfrom
devantler:devantler-explicit-custom-property-values-cla

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Summary

CustomProperty could not represent GitHub’s optional require_explicit_values setting, preventing clients such as the Terraform provider from preserving or managing it.

This adds the optional field, keeps omitted and explicit false values distinct, and covers response decoding plus batch and single-property request bodies.

Closes #4559
Supersedes #4560 to resolve contributor CLA attribution.

Assisted contribution

GitHub Copilot substantially assisted with the code, tests, and prose. I reviewed, understood, and tested every change.

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (72a2f27) to head (b8607ba).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4561   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files         197      197           
  Lines       18299    18299           
=======================================
  Hits        18038    18038           
  Misses        261      261           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread github/orgs_properties.go Outdated
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
@devantler

Copy link
Copy Markdown
Contributor Author

@Not-Dhananjay-Mishra and @gmlewis it should be ready for approval now then :-)

Comment thread github/orgs_properties_test.go Outdated
Comment thread .golangci.yml Outdated
devantler and others added 2 commits September 17, 2026 12:45
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
@devantler

Copy link
Copy Markdown
Contributor Author

@Not-Dhananjay-Mishra and @gmlewis applied the second round of review file suggestions.

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you, @Not-Dhananjay-Mishra and @devantler!
Sorry that I didn't provide helpful feedback right up front to save you a good deal of time, and thank you, @Not-Dhananjay-Mishra for guiding us here.
LGTM.

@Not-Dhananjay-Mishra - has all your feedback been addressed?

@devantler

Copy link
Copy Markdown
Contributor Author

Excellent, thank you, @Not-Dhananjay-Mishra and @devantler! Sorry that I didn't provide helpful feedback right up front to save you a good deal of time, and thank you, @Not-Dhananjay-Mishra for guiding us here. LGTM.

@Not-Dhananjay-Mishra - has all your feedback been addressed?

No worries, we all do this all the time 😃 I am happy we got it as we want it, as that is the important thing after all!

@devantler

devantler commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

This PR will be reviewed after we have gotten dev support into gh-token-exchanger :-) I still need to look through the code a bit before then.

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@gmlewis

gmlewis commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Thank you, @Not-Dhananjay-Mishra!
Merging.

@gmlewis
gmlewis merged commit cd248c6 into google:master Sep 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support require_explicit_values on custom properties

3 participants