-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test(oauth2): add mTLS in-process socket tests and live GCP WIF integration tests #14220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
macastelaz
wants to merge
22
commits into
googleapis:oauth2-bound-tokens
Choose a base branch
from
macastelaz:cert-bound-oauth-integration-tests
base: oauth2-bound-tokens
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dadeda6
feat(oauth2): implement IAM impersonation mTLS transport pinning and …
macastelaz 5cc87e0
fix(oauth2): enforce CLOUD_PLATFORM_SCOPE on impersonation source cre…
macastelaz 73c5a0a
fix(oauth2): address PR review feedback for IAM mTLS transport pinning
macastelaz 8034525
fix(oauth2): address post-review audit edge cases for mTLS pinning
macastelaz 17aae1f
fix(oauth2): preserve exact class check for MtlsHttpTransportFactory …
macastelaz f2d752e
test(oauth2): add coverage for custom MtlsHttpTransportFactory subcla…
macastelaz a5e69ed
fix(oauth2): annotate refreshAccessToken(HttpTransportFactory) with @…
macastelaz 031a594
test(oauth2): add mTLS in-process socket tests and live GCP WIF integ…
macastelaz fdfea4f
test(oauth2): escape Windows path backslashes in MtlsPipelineLocalTes…
macastelaz 4266196
test(oauth2): ensure executor shutdown and temp file cleanup in mTLS …
macastelaz 7ac9e63
test(oauth2): verify real Cert A -> Cert B rotation on 401 and harden…
macastelaz 13e8be0
fix(oauth2): address review feedback on mTLS transport pinning and 40…
macastelaz 44ca6d7
fix(oauth2): address PR #14212 round 2 review feedback
macastelaz ffe2b6d
Merge branch 'cert-bound-oauth-iam-pinning' into cert-bound-oauth-int…
macastelaz 08e026b
fix: address PR #14220 review comments on OAuthException, MtlsPipelin…
macastelaz 9313161
fix(oauth2): pin leaf subject token from KeyStore, cache STS token wi…
macastelaz 6e5f7fe
fix(oauth2): support mTLS pinning for standalone ImpersonatedCredenti…
macastelaz ddd5ea8
fix(oauth2): handle mid-rotation invalid_grant, cached STS 401 retry,…
macastelaz b47ab2a
fix(auth): harden concurrency and nullability in ImpersonatedCredenti…
macastelaz fb1a9c8
Merge branch 'cert-bound-oauth-iam-pinning' into cert-bound-oauth-int…
macastelaz 22556ff
fix(oauth2): address PR #14220 round 2 review feedback
macastelaz 849c4e5
style(oauth2): remove unused body variable in MtlsPipelineLocalTest
macastelaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
IdentityPoolCredentials.refreshAccessToken()delegates directly intorefreshWithRetry(..., true)rather than callingrefreshAccessToken(HttpTransportFactory). We should update this Javadoc to reflect the subclass behavior accurately.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the Javadoc on refreshAccessToken(HttpTransportFactory).