Skip to content

chore(storage): add storage benchmark tool for Gaxios refactor comparison - #8341

Open
thiyaguk09 wants to merge 1 commit into
googleapis:storage-gaxios-migrationfrom
thiyaguk09:chore/344856049-gaxios-benchmark
Open

thiyaguk09 wants to merge 1 commit into
googleapis:storage-gaxios-migrationfrom
thiyaguk09:chore/344856049-gaxios-benchmark

Conversation

@thiyaguk09

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label May 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new benchmarking tool in handwritten/storage/internal-tooling/benchmark.ts along with updated documentation in the README. The tool enables comparative latency and memory benchmarking between the current codebase and a specified baseline NPM version of @google-cloud/storage. Feedback focuses on improving the robustness of dynamic imports for module compatibility, replacing hardcoded values with constants, enhancing type safety by avoiding any[], and refining the throughput calculation logic.

Comment thread handwritten/storage/internal-tooling/benchmark.ts Outdated
Comment thread handwritten/storage/internal-tooling/benchmark.ts Outdated
Comment thread handwritten/storage/internal-tooling/benchmark.ts Outdated
Comment thread handwritten/storage/internal-tooling/benchmark.ts Outdated
@thiyaguk09
thiyaguk09 marked this pull request as ready for review May 21, 2026 08:26
@thiyaguk09
thiyaguk09 requested a review from a team as a code owner May 21, 2026 08:26
Comment thread handwritten/storage/internal-tooling/benchmark.ts Outdated
Comment thread handwritten/storage/internal-tooling/README.md Outdated
Comment thread handwritten/storage/internal-tooling/benchmark.ts Outdated
Comment thread handwritten/storage/internal-tooling/benchmark.ts Outdated
@Dhriti07
Dhriti07 requested a review from kalragauri May 25, 2026 07:08
@thiyaguk09
thiyaguk09 requested a review from a team as a code owner May 25, 2026 08:43
@thiyaguk09
thiyaguk09 requested a review from Dhriti07 May 25, 2026 16:05
@thiyaguk09
thiyaguk09 force-pushed the storage-node-18 branch 4 times, most recently from e3288e3 to 1fba172 Compare June 2, 2026 13:04
@thiyaguk09
thiyaguk09 force-pushed the storage-node-18 branch 3 times, most recently from c0a6220 to 0f2652b Compare June 5, 2026 14:22
@thiyaguk09
thiyaguk09 force-pushed the storage-node-18 branch 5 times, most recently from 2c0e9c8 to 696a337 Compare June 19, 2026 08:19
@shivanee-p
shivanee-p requested review from a team and removed request for a team, Dhriti07 and kalragauri June 22, 2026 21:15
@thiyaguk09
thiyaguk09 force-pushed the storage-node-18 branch 6 times, most recently from e374c96 to e6912a7 Compare August 3, 2026 07:16
@thiyaguk09
thiyaguk09 force-pushed the chore/344856049-gaxios-benchmark branch from 0b030ce to e782be2 Compare August 6, 2026 07:12
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 6 times, most recently from 0c27d9e to 00dcb72 Compare August 17, 2026 07:39
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 2 times, most recently from 644cae2 to 8edeb26 Compare August 21, 2026 10:39
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 2 times, most recently from 5421117 to d8b93e8 Compare August 28, 2026 14:16
@thiyaguk09
thiyaguk09 force-pushed the chore/344856049-gaxios-benchmark branch from 0958141 to b0cd35d Compare August 28, 2026 15:23
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 5 times, most recently from 3eb2445 to d749fc2 Compare September 4, 2026 07:18
@thiyaguk09
thiyaguk09 force-pushed the storage-gaxios-migration branch 5 times, most recently from 8b3e2ad to 35de221 Compare September 9, 2026 01:29
…ison

refactor: clean up benchmark utility with improved formatting and added imports

feat: add support for selective scenario execution in storage benchmarks

refactor: remove unnecessary line breaks in list files benchmark call

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants