Skip to content

Add WebAssembly support (GOARCH=wasm). #25

Open

Description

@silbinarywolf

This package should be updated to use the following library so that websocket usage can target wasm and gopherjs:
"github.com/gopherjs/gopherwasm/js"

This will require wrapping callbacks with js.NewEventCallback() (and calling .Release()) and changing *js.Object to js.Value

Activity

  1. silbinarywolf commented on Sep 7, 2018

    @silbinarywolf
    Author

    I have something functional but not elegant available for those interested here:
    #26

    I'm not really interested in covering this off properly as I will most likely move away from Websocket in the future.

  2. changed the title [-]Does not work with Go 1.11 and WASM build[/-] [+]Add WebAssembly support (GOARCH=wasm).[/+] on Sep 10, 2018
  3. dmitshur commented on Sep 12, 2018

    @dmitshur
    Member

    Thanks for opening the issue, and for sending a draft PR!

    I tested it with one of my projects that uses WebSockets just now, and I can see that it compiles and functions partially, but after some amount of bytes (or messages), there is a discrepancy in the data sent/received, causing my protocol to report an error.

    Still, it's helpful to have it as a reference, so thanks for providing it!

  4. nhooyr commented on Sep 22, 2019

    @nhooyr
    Contributor

    @dmitshur Instead of adding support for WASM to this package, what are your thoughts on recommending my WebSocket package instead? The client side can target WASM directly with nearly the same API as for non WASM targets

    See coder/websocket#142

    It should also work for GopherJS once GopherJS supports Go 1.13.

    This would also resolve #29 and every other issue/PR on this library.

  5. added a commit that references this issue on Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions