Repository navigation
Conversation
Contributor
|
Previews, as seen when this build job started (d1e3142): |
This was referenced Sep 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per gpuweb/cts#4708 current wording of spec is wrong. This intention of #5114 was to raise AbortError (
deviceLost=true) when device is invalid (lost) and raise OperationError on invalid buffer. Device check happens before buffer validity check.This matches what dawn does:
https://github.com/google/dawn/blob/723d1f04c9d4bae31e67ca7a33589aeb0849efab/src/dawn/native/Buffer.cpp#L815-L817
I discovered the problem while working on wgpu (which powers Servo and Firefox), which currently does buffer validity then device validity check but maps both to OperationError.
Added CTS tests: gpuweb/cts#4713