Conversation
Cache the precomputed serviceUrl used by call credentials in a bounded two-level cache on InternalChannel instead of re-parsing the method path, splitting the host, and constructing a new template string on every RPC. - Add zero-allocation `extractServiceName` and `computeServiceUrl` helpers in `uri-parser.ts`. - Introduce a bounded two-level cache (`serviceUrlCache: Map<string, Map<string, string>>`) on `InternalChannel`, capped at 5 hosts and 100 methods per host to strictly bound memory while achieving zero-allocation lookups on cache hits. - Clear `serviceUrlCache` when the channel is closed. - Update `LoadBalancingCall` and `SingleSubchannelChannel` to use the shared URL computation and caching.
murgatroid99
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the precomputed serviceUrl used by call credentials in a bounded two-level cache on InternalChannel instead of re-parsing the method path, splitting the host, and constructing a new template string on every RPC.
extractServiceNameandcomputeServiceUrlhelpers inuri-parser.ts.serviceUrlCache: Map<string, Map<string, string>>) onInternalChannel, capped at 5 hosts and 100 methods per host to strictly bound memory while achieving zero-allocation lookups on cache hits.serviceUrlCachewhen the channel is closed.LoadBalancingCallandSingleSubchannelChannelto use the shared URL computation and caching.