Skip to content

fix: jump to reviewer from comment pane #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sackbuoy wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: jump to reviewer from comment pane #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lua/gitlab/actions/common.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,10 @@ M.get_line_numbers_for_range = function(old_line, new_line, start_line_code, end
local old_start_line, new_start_line = indicators_common.parse_line_code(start_line_code)
local old_end_line, new_end_line = indicators_common.parse_line_code(end_line_code)
if old_line ~= nil and old_start_line ~= 0 then
local range = old_end_line - old_start_line
local range = (old_end_line ~= nil and old_start_line ~= nil) and (old_end_line - old_start_line) or 0
return (old_line - range), old_line, false
elseif new_line ~= nil then
local range = new_end_line - new_start_line
local range = (new_end_line ~= nil and new_start_line ~= nil) and (new_end_line - new_start_line) or 0
-- Force start_line to be greater than 0
-- TODO: use `math.max(new_line - range, 1)` instead
local start_line = (new_line - range > 0) and (new_line - range) or 1
Expand Down