Repository navigation
Implement readFile in Terms of withFile for Prompt Closing of Handle - #714
Merged
Merged
Conversation
Bodigrim
approved these changes
Sep 27, 2026
Contributor
|
Can we write a regression test? |
Lysxia
approved these changes
Oct 6, 2026
Contributor
Author
|
Sorry! I've been meaning to come back to this and add a regression test but got swamped with work and other things last week and this one. Thank you for completing the PR! |
Contributor
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
Data.Text.IO.readFilein terms ofSystem.IO.withFileinstead ofSystem.IO.openFile. This ensures the handle is closed immediately in case of an exception, something thatData.Text.IO.hGetContentsby itself does not guarantee.There is more discussion about this in #712.