Skip to content

Fetch Docker secrets from AWS Secrets Manager - #565

Merged
mchatlas-hellosign merged 1 commit into
mainfrom
chore/fetch-docker-secrets-from-aws
Sep 15, 2026
Merged

mchatlas-hellosign merged 1 commit into
mainfrom
chore/fetch-docker-secrets-from-aws

Conversation

@mchatlas-hellosign

Copy link
Copy Markdown
Member

Summary

  • authenticate to AWS from the build jobs using branch-restricted GitHub OIDC
  • load the shared Docker Hub username and token from AWS Secrets Manager
  • allow pull-request builds to run without attempting Docker Hub login
  • remove GitHub Actions secret references for Docker credentials

Verification

  • git diff --check
  • parsed .github/workflows/github-actions.yml with Ruby YAML aliases enabled
  • bash -n on bin/php and every SDK run-build script
  • GitHub Actions pull-request build

Based on the AWS secret-fetching pattern in hellosign/dropbox-sign-node#36.

@mchatlas-hellosign
mchatlas-hellosign merged commit 7cbca50 into main Sep 15, 2026
9 checks passed
@mchatlas-hellosign
mchatlas-hellosign deleted the chore/fetch-docker-secrets-from-aws branch September 15, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants