fix: only send load balancer service certificates when defined - #690
Merged
Merged
Conversation
The to_payload function was always adding the certificates to the payload, which is not an expected behavior if we want to support partial updates.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 76 76
Lines 4098 4099 +1
=======================================
+ Hits 3980 3981 +1
Misses 118 118 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jooola
pushed a commit
that referenced
this pull request
Sep 17, 2026
<!-- section-start changelog --> ### Features - list network members (#687) ([9d5d21d](9d5d21d)) ### Bug Fixes - only send load balancer service certificates when defined (#690) ([c6bc24a](c6bc24a)) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ~~~~rp-prefix ~~~~ ### Suffix / End This will be added to the end of the release notes. ~~~~rp-suffix ~~~~ </details> Co-authored-by: Hetzner Cloud Bot <>
jooola
added a commit
to ansible-collections/hetzner.hcloud
that referenced
this pull request
Sep 17, 2026
…uments (#870) ##### SUMMARY - Modernize the module to simplify the code - Fix the module always reporting a change when the `http` or `health_check` arguments were set, even when the current configuration already matched the desired state. Closes #415 ##### ISSUE TYPE - Bugfix Pull Request ##### COMPONENT NAME load_balancer_service ##### ADDITIONAL INFORMATION This PR depends on hetznercloud/hcloud-python#690.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
to_payloadmethod was always adding the load balancer servicescertificatesto the payload, which is not an expected behavior if we want to support partial updates.