Skip to content

fix(core): scope GSAP selector arrays within compositions - #4089

Closed
lorenzozanee wants to merge 1 commit into
heygen-com:mainfrom
lorenzozanee:fix/core-scope-gsap-array-targets
Closed

lorenzozanee wants to merge 1 commit into
heygen-com:mainfrom
lorenzozanee:fix/core-scope-gsap-array-targets

Conversation

@lorenzozanee

Copy link
Copy Markdown
Contributor

Scope selector strings inside GSAP target arrays to the active composition root and add regression coverage for cross-composition leakage.

The resolver now scopes each string entry and preserves non-string targets, preventing selectors from resolving against the whole document when compositions are bundled. The focused composition-scoping test suite passes with 57 tests.

Validation:

  • bun run --cwd packages/core test -- src/compiler/compositionScoping.test.ts
  • bun run --cwd packages/core typecheck
  • bunx oxfmt --check packages/core/src/compiler/compositionScoping.ts packages/core/src/compiler/compositionScoping.test.ts
  • bunx oxlint packages/core/src/compiler/compositionScoping.ts packages/core/src/compiler/compositionScoping.test.ts
  • git diff --check

Fixes #4034

@miguel-heygen
miguel-heygen enabled auto-merge (squash) September 18, 2026 15:12
@miguel-heygen

Copy link
Copy Markdown
Collaborator

Thank you for this. The same fix is already on main via #4035, so this one is no longer needed. Closing; happy to reopen if you see the problem still happening on the latest release.

auto-merge was automatically disabled October 2, 2026 15:52

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composition scope shim doesn't scope array selector targets: tweens leak across compositions (element stays visibility:hidden for a whole beat)

2 participants