Repository navigation
fix(core): scope GSAP selector arrays within compositions - #4089
Closed
lorenzozanee wants to merge 1 commit into
Closed
lorenzozanee wants to merge 1 commit into
lorenzozanee wants to merge 1 commit into
Conversation
miguel-heygen
approved these changes
Sep 18, 2026
miguel-heygen
enabled auto-merge (squash)
September 18, 2026 15:12
Collaborator
|
Thank you for this. The same fix is already on main via #4035, so this one is no longer needed. Closing; happy to reopen if you see the problem still happening on the latest release. |
auto-merge was automatically disabled
October 2, 2026 15:52
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope selector strings inside GSAP target arrays to the active composition root and add regression coverage for cross-composition leakage.
The resolver now scopes each string entry and preserves non-string targets, preventing selectors from resolving against the whole document when compositions are bundled. The focused composition-scoping test suite passes with 57 tests.
Validation:
Fixes #4034