Repository navigation
Repair CodeQL imported-module extraction and enforce diagnostic failures - #17
Draft
hideouts-io wants to merge 9 commits into
Draft
hideouts-io wants to merge 9 commits into
hideouts-io wants to merge 9 commits into
Conversation
hideouts-io
marked this pull request as draft
October 14, 2026 07:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Repair incomplete imported-module semantics in Swift CodeQL analysis while retaining a strict extraction-quality gate and bounded failure evidence.
Current state: blocked on one extractor diagnostic
The latest CodeQL run at
ec5118acompleted its Xcode 26.6 build and all three language analyses, but the Swift SARIF still contains oneswift/diagnostics/extraction-errorsnotification atlevel: none:reference to 'NSAccessibilityElement' is ambiguous. It has no owned-source location. The gate correctly rejected it; upload jobs were skipped andCodeQL resultsfailed. This PR is not ready to merge.The bounded invocation summary agrees with SARIF: zero compiler errors in the diagnostic helper and app invocations, and one in
SystemProfilerExplorerTests(28 source arguments). The tested runner used Xcode 26.6 / Apple Swift 6.3.3 / MacOSX26.5.sdk. All 100 Git-owned Swift paths match the expected and located extracted path sets. This file count, zero unresolved AST nodes, and zero security query results do not establish complete imported-module semantics.The Xcode 26.6 selection and version-report step are a recorded compatibility trial, not a correction for this diagnostic. The same ambiguity was present with Xcode 26.4.1 in the previous run. A public CodeQL issue independently reproduces this ambiguity with valid PDFKit source; that report does not prove which import causes this repository's test-module diagnostic or provide a supported remedy.
Scope retained
level: none, before the separate SARIF upload job can execute.Verification and remaining work
Local publication-boundary check, branding type check, Swift 6 helper compilation with warnings treated as errors, and Xcode 27 native build/tests passed: 195 passed, one optional private-fixture skip, zero failed. Hosted native CI passed at this head; the hosted 196-test total likewise includes that optional skip. JavaScript/TypeScript and Actions CodeQL analyses passed. Swift SARIF still has the one diagnostic above; processed uploads and the aggregate CodeQL gate did not pass.
Resolve the extractor diagnostic without suppressing it or excluding source/tests, then rerun Swift extraction and compare SARIF with bounded invocation evidence. Require zero compiler diagnostics, complete owned-path coverage, processed uploads for all three languages, and a passing aggregate gate at the candidate revision. The newer app work in PR #18 must be checked again when combined with this workflow.
No product release, deployment, signing, or notarization is performed by this PR.