Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
make up/test/rediscluster+make test/e2e/redisclusterrun the Redis Cluster e2e suite again. It had drifted and either failed to start or ran no tests.test/e2e/redisclusterran-run TestRedisClusterBasicSuite, which no longer exists, so it matched nothing. Now-run TestE2E_Compat_RedisCluster.postgres,clickhouse,mock, …). Now it uses themake up/testcontainers (test-postgres,test-clickhouse,test-mock) and addsTEST_NATS_URL, which e2e needs since NATS became the default internal MQ. The RabbitMQ/LocalStack/GCP/Azure entries pointed at nothing and are gone.TESTCOMPAT=1is set on the test-runner, since the suite skips without it.grokzen/redis-cluster:7.2.4sets a locale it doesn't ship and Redis exits on start, so the cluster never came up on Linux.LC_ALL=Cfixes it.contributing/test.mddocumented aTESTREDISCLUSTERvariable that nothing reads; removed.With this, the suite runs end to end. 4 subtests fail (
TestRetry_FailedDeliveryAutoRetries,TestRetry_ManualRetryCreatesNewAttempt,TestRetry_DuplicateManualRetryExecutesBoth,TestOpEvents_ExhaustedRetries) on a real bug: the retry queue's keys span two cluster slots. The fix is #1139, stacked on this one.To run:
make up/test && make up/test/rediscluster && make test/e2e/rediscluster.🤖 Generated with Claude Code