Don't fully-qualify "static" as a return type - #77
Merged
janlam7 merged 1 commit intoSep 14, 2026
Conversation
ReflectionType::getName() qualified any type not in NON_QUALIFIED_TYPES
with a leading backslash, but "static" is a reserved word, not a class
name — emitting "\static" as a generated interface method's return
type is invalid PHP ("'\static' is an invalid class name").
Add "static" to NON_QUALIFIED_TYPES alongside "self". Surfaced by
HNB-3627: hostnet/entity-blamable-component 2.0.0 widened
BlamableInterface's setters to "static" return types, so any entity
implementing it and going through entity-plugin-lib's combined
interface generator hit this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReflectionType::getName() qualified any type not in NON_QUALIFIED_TYPES with a leading backslash, but "static" is a reserved word, not a class name — emitting "\static" as a generated interface method's return type is invalid PHP ("'\static' is an invalid class name").
Triggered by having static as return-type in https://github.com/hostnet/entity-blamable-component/blob/master/src/BlamableInterface.php