Remove annotation support - #38
Merged
Merged
Conversation
janlam7
commented
Sep 14, 2026
janlam7
commented
Contributor
- Removes annotation support
- Not a BC break by itself, but entity-*-component are BC breaked
- Add #[\Override] on interface/parent-overriding methods. - Use constructor property promotion in DefaultBlamableProvider and type the previously-untyped properties in the test suite. - Replace PHPUnit's deprecated setMethods() mock builder call with onlyMethods(). - Remove PHPDoc that only restated a typed signature. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
- Bump actions/checkout v2 -> v7 (v2 runs on the deprecated Node 16 runtime). - Bump actions/cache v4 -> v6. - Add PHP 8.4 to the test matrix alongside 8.3, matching entity-blamable/mutation/revision-component's own workflows. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
symfony/console is only ever a transitive dependency here (pulled in loosely by doctrine/orm and by conflict guards in framework-bundle/ http-kernel/security-bundle/symfony/yaml), and nothing capped its upper bound. On PHP 8.4, Composer's solver was free to pick symfony/console 8.0.x (itself requiring php >=8.4), whose abstract Command::configure() now declares a ": void" return type that symfony/yaml 6.4's LintCommand::configure() (still untyped) doesn't satisfy - a fatal "Declaration ... must be compatible with ..." the moment framework-bundle's console/command wiring loads that class. On PHP 8.3 the same console 8.0.x is filtered out by its own php requirement during resolution, so the break was invisible until the 8.4 matrix leg was added. A conflict entry (rather than a fake require-dev on a package this bundle never actually uses) keeps composer.json honest about what's really a dependency here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
phonixor
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.