docs: clarify host function access control in security.md - #1799
Merged
Conversation
Clarify the registration process for host functions in the sandbox and emphasize the importance of access control for untrusted guests. Signed-off-by: commSync <51642194+JM00NJ@users.noreply.github.com>
JM00NJ
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
September 4, 2026 21:41
jsturtevant
approved these changes
Sep 4, 2026
jprendes
approved these changes
Sep 8, 2026
jprendes
enabled auto-merge (squash)
September 8, 2026 10:14
Contributor
|
I think this needs a rebase? I'm not sure why it didn't auto merge |
jprendes
approved these changes
Sep 8, 2026
Contributor
|
Thanks for your contribution @JM00NJ ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous wording implied that
#[host_function]declarationsin guest code control which host functions a guest can access.
This is not the case; all functions registered via
sandbox.register()are callable by any guest in that sandbox.
This PR clarifies:
sandbox.register(), not#[host_function]#[host_function]is compile-time syntactic sugar, not a security boundaryFollows up on security advisory discussion.